verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

fix: setDeleted #2947

Merged
carlossa merged 2 commits from hotfix7960-setDeleted into master 2024-09-11 06:51:55 +00:00
Conversation 0 Commits 2 Files Changed 1 +1 -1
carlossa commented 2024-09-11 06:36:38 +00:00
Member
Copy Link
No description provided.
carlossa added the
CR / Tests passed
 label 2024-09-11 06:36:38 +00:00
carlossa added 1 commit 2024-09-11 06:36:38 +00:00
gitea/salix/pipeline/pr-master This commit looks good Details
ccaf56f842 fix: setDeleted
carlossa requested review from alexm 2024-09-11 06:40:19 +00:00
alexm requested changes 2024-09-11 06:44:41 +00:00
Dismissed
modules/ticket/back/methods/ticket/setDeleted.js Outdated
@ -128,3 +128,3 @@
url: `${url}ticket/${id}/summary`
});
await models.Chat.send(ctx, `@${salesPersonUser.name}`, message);
await models.Chat.sendCheckingPresence(ctx, `${salesPersonUser.id}`, message);
alexm commented 2024-09-11 06:44:39 +00:00
Member
Copy Link

Poner directamente salesPersonUser.id

Poner directamente salesPersonUser.id
carlossa marked this conversation as resolved
carlossa added 1 commit 2024-09-11 06:45:10 +00:00
gitea/salix/pipeline/pr-master This commit looks good Details
838b8f541f fix: setDeleted
carlossa requested review from alexm 2024-09-11 06:45:17 +00:00
alexm approved these changes 2024-09-11 06:45:49 +00:00
carlossa merged commit 6c8c617837 into master 2024-09-11 06:51:55 +00:00
carlossa deleted branch hotfix7960-setDeleted 2024-09-11 06:51:55 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexm
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2947
No description provided.
Delete Branch "hotfix7960-setDeleted"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?