verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

locallyTested #2956

Merged
pako merged 2 commits from 7969-hasPlantTray into dev 2024-09-12 12:46:44 +00:00
Conversation 0 Commits 2 Files Changed 3 +22 -5
pako commented 2024-09-12 12:14:23 +00:00
Member
Copy Link
No description provided.
pako added 1 commit 2024-09-12 12:14:24 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
b1027f454b locallyTested
pako requested review from carlosap 2024-09-12 12:15:33 +00:00
carlosap requested changes 2024-09-12 12:30:46 +00:00
Dismissed
db/routines/vn/procedures/productionControl.sql Outdated
@ -268,0 +268,4 @@
UPDATE tmp.productionBuffer pb
JOIN sale s ON s.ticketFk = pb.ticketFk
JOIN item i ON i.id = s.itemFk
JOIN itemType it ON it.id = i.typeFk
carlosap commented 2024-09-12 12:29:02 +00:00
Member
Copy Link

EL JOIN encara que es raro en el UDPATE tabulem 2 vegades

EL JOIN encara que es raro en el UDPATE tabulem 2 vegades
pako commented 2024-09-12 12:34:27 +00:00
Author
Member
Copy Link

fet

fet
db/routines/vn/procedures/productionControl.sql
@ -268,0 +276,4 @@
JOIN productionConfig pc
SET hasPlantTray = TRUE
WHERE ic.code = 'plant'
AND p.`depth` >= pc.minPlantTrayLength;
carlosap commented 2024-09-12 12:30:12 +00:00
Member
Copy Link

No deuria de ser > i no >=?

No deuria de ser > i no >=?
pako commented 2024-09-12 12:33:01 +00:00
Author
Member
Copy Link

No, es correcte. Es la mida a partir de la cual volen la restricció

No, es correcte. Es la mida a partir de la cual volen la restricció
pako marked this conversation as resolved
pako added 1 commit 2024-09-12 12:34:22 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
a0bfc20595 revision
pako requested review from carlosap 2024-09-12 12:34:36 +00:00
carlosap approved these changes 2024-09-12 12:44:19 +00:00
pako merged commit bd47420e82 into dev 2024-09-12 12:46:44 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
carlosap
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2956
No description provided.
Delete Branch "7969-hasPlantTray"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?