verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

#7884 added new filter field #2981

Merged
jon merged 15 commits from 7884-AddLabelerField into dev 2024-10-02 05:04:18 +00:00
Conversation 0 Commits 15 Files Changed 2 +51 -12
jon commented 2024-09-17 06:32:18 +00:00
Member
Copy Link
No description provided.
jon added 1 commit 2024-09-17 06:32:19 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
1d47690bb4 feat: refs #7884 added new filter field
jon requested review from alexm 2024-09-17 06:42:52 +00:00
alexm requested changes 2024-09-17 10:06:51 +00:00
Dismissed
modules/entry/back/methods/entry/filter.js Outdated
@ -217,3 +222,3 @@
);
if (ctx.args.days) {
if (ctx.args.daysOnward) {
alexm commented 2024-09-17 10:06:48 +00:00
Member
Copy Link

Revisar si estan los dos a la vez

Revisar si estan los dos a la vez
jon marked this conversation as resolved
jon added 1 commit 2024-09-17 10:42:55 +00:00
jon added 1 commit 2024-09-17 10:44:33 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
33c3ceaf33 Merge branch 'dev' into 7884-AddLabelerField
jon requested review from alexm 2024-09-17 11:21:57 +00:00
jon added 1 commit 2024-09-18 06:23:47 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
35358834d9 Merge branch 'dev' into 7884-AddLabelerField
jon added 1 commit 2024-09-20 08:24:44 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
2fc07e651f Merge branch 'dev' into 7884-AddLabelerField
jon added 1 commit 2024-09-23 06:52:03 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
6650673c7d Merge branch 'dev' into 7884-AddLabelerField
jon added 1 commit 2024-09-24 08:44:38 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
1e07a2fc59 Merge branch 'dev' into 7884-AddLabelerField
jon added 1 commit 2024-09-25 06:02:48 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
26d7866ec8 Merge branch 'dev' into 7884-AddLabelerField
alexm reviewed 2024-09-30 08:12:19 +00:00
modules/entry/back/methods/entry/filter.js Outdated
@ -222,1 +224,3 @@
AND t.shipped <= util.VN_CURDATE() + INTERVAL ? DAY
const {daysAgo, daysOnward} = ctx.args;
if (daysAgo || daysOnward) {
alexm commented 2024-09-30 08:12:19 +00:00
Member
Copy Link

Jo li diria a chatgpt si teu pot simplificar

Jo li diria a chatgpt si teu pot simplificar
alexm requested changes 2024-09-30 08:12:42 +00:00
Dismissed
alexm left a comment
Member
Copy Link

Si no se pot dime i aprove

Si no se pot dime i aprove
alexm requested changes 2024-09-30 08:13:53 +00:00
Dismissed
alexm left a comment
Member
Copy Link

Y crec q per com esta podria fallar si no hi ha algo mes en el where antes. Pq fer un and de primeres dona fallo, es a dir fer: WHERE AND...

Y crec q per com esta podria fallar si no hi ha algo mes en el where antes. Pq fer un and de primeres dona fallo, es a dir fer: `WHERE AND...`
jon added 3 commits 2024-09-30 10:08:03 +00:00
jon added 1 commit 2024-09-30 10:46:47 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
c4f26094d5 fix: refs #7884 fixed filter
jon added 1 commit 2024-10-01 13:08:51 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
b7b5334a99 refactor: refs #7884 modified filter
jon added 1 commit 2024-10-01 13:10:23 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
d73f790221 Merge branch 'dev' into 7884-AddLabelerField
jon requested review from alexm 2024-10-01 13:12:01 +00:00
alexm approved these changes 2024-10-01 13:14:47 +00:00
jon added 1 commit 2024-10-02 04:55:58 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
2267b2c6b1 Merge branch 'dev' into 7884-AddLabelerField
jon merged commit 2fbf8478c0 into dev 2024-10-02 05:04:18 +00:00
jon deleted branch 7884-AddLabelerField 2024-10-02 05:04:18 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexm
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2981
No description provided.
Delete Branch "7884-AddLabelerField"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?