verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

feat: refs #7880 modify hedera.order_confirmWithUser #3001

Closed
ivanm wants to merge 2 commits from 7880-modifyHedera.order_confirmWithUser into dev
pull from: 7880-modifyHedera.order_confirmWithUser
merge into: verdnatura:dev
Conversation 1 Commits 2 Files Changed 6 +31 -7
ivanm commented 2024-09-22 06:14:04 +00:00
Member
Copy Link
No description provided.
ivanm added 1 commit 2024-09-22 06:14:05 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
b6420b639c feat: refs #7880 modify hedera.order_confirmWithUser
ivanm requested review from juan 2024-09-22 06:15:59 +00:00
juan requested changes 2024-10-03 14:58:51 +00:00
db/routines/hedera/procedures/order_confirmWithUser.sql
@ -112,2 +112,4 @@
END IF;
-- Check if any product has a quantity of 0
SELECT COUNT(*) INTO vHasRows
juan commented 2024-10-03 14:58:45 +00:00
Owner
Copy Link

Renombrar variable a vHasZeroRows para que no genere confusión con que el pedido no tenga lineas.

Renombrar variable a `vHasZeroRows` para que no genere confusión con que el pedido no tenga lineas.
ivanm marked this conversation as resolved
db/routines/hedera/procedures/order_confirmWithUser.sql Outdated
@ -114,0 +118,4 @@
AND amount = 0;
IF vHasRows THEN
CALL util.throw('Remove lines with quantity = 0 before confirming');
juan commented 2024-10-03 14:58:08 +00:00
Owner
Copy Link

Cambiar mensaje por un código para poderlo traducir, del estilo: orderLinesWithZero

Cambiar mensaje por un código para poderlo traducir, del estilo: `orderLinesWithZero`
ivanm marked this conversation as resolved
ivanm added 1 commit 2024-10-08 15:31:59 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
d43f960963 feat: refs #7880 requested modifications and translations
ivanm commented 2024-10-16 14:01:04 +00:00
Author
Member
Copy Link

Realizado por Pako en la tarea #8069

Realizado por Pako en la tarea #8069
ivanm closed this pull request 2024-10-16 14:01:04 +00:00
ivanm deleted branch 7880-modifyHedera.order_confirmWithUser 2024-10-16 14:01:21 +00:00
Some checks failed
gitea/salix/pipeline/pr-dev There was a failure building this commit
Required
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
juan
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#3001
No description provided.
Delete Branch "7880-modifyHedera.order_confirmWithUser"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?