verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

7404-fixStockBought #3004

Merged
pablone merged 9 commits from 7404-fixStockBought into dev 2024-09-24 09:32:50 +00:00
Conversation 0 Commits 9 Files Changed 8 +94 -71
pablone commented 2024-09-23 08:05:39 +00:00
Member
Copy Link
No description provided.
pablone added 2 commits 2024-09-23 08:05:39 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
459f6601b7 fix: refs #7404 add transaction on detail calculate
pablone added 1 commit 2024-09-23 08:14:15 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
80985fbd56 fix: refs #7404 round data and fix specs
pablone requested review from jgallego 2024-09-23 08:16:11 +00:00
pablone added 1 commit 2024-09-23 08:16:20 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
ab89c8f3ba Merge branch 'dev' into 7404-fixStockBought
jgallego requested changes 2024-09-23 11:54:46 +00:00
Dismissed
modules/entry/back/methods/stock-bought/getStockBought.js Outdated
@ -31,3 +31,2 @@
if (dated.getTime() === today.getTime())
await models.StockBought.rawSql(`CALL vn.stockBought_calculate()`);
if (dated.getTime() >= today.getTime())
jgallego commented 2024-09-23 11:54:44 +00:00
Owner
Copy Link

açò es pareix molt a la comprobacio que fa el procediment. Si fos lo mateix, millor no repetir codi

açò es pareix molt a la comprobacio que fa el procediment. Si fos lo mateix, millor no repetir codi
pablone marked this conversation as resolved
modules/item/back/methods/item/specs/lastEntriesFilter.spec.js
@ -14,3 +14,3 @@
const result = await models.Item.lastEntriesFilter(filter, options);
expect(result.length).toEqual(1);
expect(result.length).toEqual(2);
jgallego commented 2024-09-23 11:53:53 +00:00
Owner
Copy Link

el test diu una entrada pero li has posat 2

el test diu una entrada pero li has posat 2
pablone marked this conversation as resolved
pablone added 2 commits 2024-09-24 05:31:29 +00:00
pablone requested review from jgallego 2024-09-24 05:31:31 +00:00
pablone added 1 commit 2024-09-24 05:31:36 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
bfd52b8773 Merge branch 'dev' into 7404-fixStockBought
jgallego requested changes 2024-09-24 05:37:26 +00:00
Dismissed
modules/item/back/methods/item/specs/lastEntriesFilter.spec.js
@ -38,3 +38,3 @@
const result = await models.Item.lastEntriesFilter(filter, options);
expect(result.length).toEqual(5);
expect(result.length).toEqual(6);
jgallego commented 2024-09-24 05:37:23 +00:00
Owner
Copy Link

en este lo mateix. posa un five i ara es 6, lo ideal seria trobar la forma de ferlos dinamics, saber perque antes agafaba 5 i fer el select ahí. Si ho veus viable ho canvies.

en este lo mateix. posa un five i ara es 6, lo ideal seria trobar la forma de ferlos dinamics, saber perque antes agafaba 5 i fer el select ahí. Si ho veus viable ho canvies.
pablone commented 2024-09-24 06:57:52 +00:00
Author
Member
Copy Link

al ser test de un filter hauria de fer la mateixa consulta del filter per a obtindre les dades inicials

al ser test de un filter hauria de fer la mateixa consulta del filter per a obtindre les dades inicials
pablone marked this conversation as resolved
pablone added 2 commits 2024-09-24 06:55:52 +00:00
pablone requested review from jgallego 2024-09-24 06:59:31 +00:00
jgallego approved these changes 2024-09-24 09:07:07 +00:00
pablone merged commit d608b3b9c8 into dev 2024-09-24 09:32:50 +00:00
pablone deleted branch 7404-fixStockBought 2024-09-24 09:32:51 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#3004
No description provided.
Delete Branch "7404-fixStockBought"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?