verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

8030-newPriceComponent #3010

Merged
pako merged 6 commits from 8030-newPriceComponent into dev 2024-09-24 08:43:59 +00:00
Conversation 0 Commits 6 Files Changed 2 +72 -11
pako commented 2024-09-24 06:51:22 +00:00
Member
Copy Link
No description provided.
pako added 2 commits 2024-09-24 06:51:23 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
acabd3e154 feat(catalog_componentCalculate): refs #8030 new component improved 
The procedure has now the component "bonus", a special price increasing for a group of items

Refs: #8030
pako requested review from jgallego 2024-09-24 06:51:30 +00:00
jgallego requested changes 2024-09-24 07:01:30 +00:00
Dismissed
db/routines/vn/procedures/catalog_componentCalculate.sql
@ -32,0 +34,4 @@
FROM vn.item i
JOIN cache.last_buy lb ON lb.item_id = i.id AND lb.warehouse_id = vWarehouseFk
JOIN buy b ON b.id = lb.buy_id
JOIN tmp.priceDelta pd
jgallego commented 2024-09-24 06:58:01 +00:00
Owner
Copy Link

d'on apareix esta taula? que significa Delta?

d'on apareix esta taula? que significa Delta?
jgallego commented 2024-09-24 07:03:11 +00:00
Owner
Copy Link

intenta gastar un nom intuitiu per a que un informàtic sols llegint puga deduir que es ixa taula

intenta gastar un nom intuitiu per a que un informàtic sols llegint puga deduir que es ixa taula
pako commented 2024-09-24 08:23:47 +00:00
Author
Member
Copy Link

Ho vaig mirar en la AI, i em va donar varies opcions. Aquesta és la millor, perque delta es la lletra grega que fan servir els matemàtics per a indicar un increment, i per tant, quan es parla de delta, en general, fas referència a increments sobre una variable. I en el comentari de la taula està explicat en detall.

Ho vaig mirar en la AI, i em va donar varies opcions. Aquesta és la millor, perque delta es la lletra grega que fan servir els matemàtics per a indicar un increment, i per tant, quan es parla de delta, en general, fas referència a increments sobre una variable. I en el comentari de la taula està explicat en detall.
db/routines/vn/procedures/catalog_componentCalculate.sql
@ -108,6 +129,17 @@ BEGIN
JOIN tmp.ticketComponentCalculate tcc ON tcc.itemFk = tc.itemFk AND tcc.warehouseFk = tc.warehouseFk
GROUP BY tc.itemFk, warehouseFk;
-- priceDelta Bonus del comprador a un rango de productos Refs: #8030
jgallego commented 2024-09-24 07:01:28 +00:00
Owner
Copy Link

les referencies al redmine no les deixem perque amb el temps es poden fer canvis i ja no tenen sentit. Amb la linea
-- Bonus del comprador a un rango de productos
suficient

les referencies al redmine no les deixem perque amb el temps es poden fer canvis i ja no tenen sentit. Amb la linea -- Bonus del comprador a un rango de productos suficient
pako commented 2024-09-24 08:24:54 +00:00
Author
Member
Copy Link

ok

ok
pako added 1 commit 2024-09-24 07:05:35 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
fb7208d898 fix: refs #8030 warehouse filter 
Warehouse is also needed to make the filter

Refs: #8030
pako added 1 commit 2024-09-24 08:27:31 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
91801b1979 fix: refs #8030 redmine revision updates 
Changes recomended by the reviewer

Refs: #8030
pako requested review from jgallego 2024-09-24 08:27:37 +00:00
pako added 2 commits 2024-09-24 08:39:32 +00:00
5c8f42a3ae fix: refs #8030 redmine revision updates 
Changes recomended by the reviewer

Refs: #8030
jgallego approved these changes 2024-09-24 08:43:18 +00:00
pako merged commit 5c4849b60d into dev 2024-09-24 08:43:59 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#3010
No description provided.
Delete Branch "8030-newPriceComponent"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?