verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

feat(ClaimBeginning): throw error when quantity claimed is greater than quantity of line #3031

Merged
alexm merged 1 commits from hotFix_claimBeginning_quantity into master 2024-09-30 12:05:14 +00:00
Conversation 0 Commits 1 Files Changed 6 +74 -12
alexm commented 2024-09-30 06:04:48 +00:00
Member
Copy Link

https://cau.verdnatura.es/scp/tickets.php?number=225023

https://cau.verdnatura.es/scp/tickets.php?number=225023
alexm added 1 commit 2024-09-30 06:04:49 +00:00
alexm reviewed 2024-09-30 06:09:22 +00:00
modules/claim/back/methods/claim-beginning/specs/claim-beginning.spec.js
@ -0,0 +1,55 @@
const models = require('vn-loopback/server/server').models;
const LoopBackContext = require('loopback-context');
describe('ClaimBeginning model()', () => {
alexm commented 2024-09-30 06:09:22 +00:00
Author
Member
Copy Link

He creat esta tarea per a ficarli tests als altres errors que hi ha en el model
https://redmine.verdnatura.es/issues/8054

He creat esta tarea per a ficarli tests als altres errors que hi ha en el model https://redmine.verdnatura.es/issues/8054
alexm requested review from jgallego 2024-09-30 06:09:36 +00:00
alexm changed title from feat(ClaimBeginning): throw error when quantity claimed is greater than quantity of line to feat(ClaimBeginning): throw error when quantity claimed is greater than quantity of line https://cau.verdnatura.es/scp/tickets.php?number=225023 2024-09-30 06:09:50 +00:00
alexm changed title from feat(ClaimBeginning): throw error when quantity claimed is greater than quantity of line https://cau.verdnatura.es/scp/tickets.php?number=225023 to feat(ClaimBeginning): throw error when quantity claimed is greater than quantity of line [Cau](https://cau.verdnatura.es/scp/tickets.php?number=225023) 2024-09-30 06:10:17 +00:00
alexm changed title from feat(ClaimBeginning): throw error when quantity claimed is greater than quantity of line [Cau](https://cau.verdnatura.es/scp/tickets.php?number=225023) to feat(ClaimBeginning): throw error when quantity claimed is greater than quantity of line 2024-09-30 06:10:25 +00:00
jgallego approved these changes 2024-09-30 06:48:17 +00:00
alexm merged commit 568a77aa19 into master 2024-09-30 12:05:14 +00:00
alexm deleted branch hotFix_claimBeginning_quantity 2024-09-30 12:05:14 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#3031
No description provided.
Delete Branch "hotFix_claimBeginning_quantity"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?