verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

#7202 added new field in InvoiceOut module #3034

Open
jon wants to merge 13 commits from 7202-AddCustomAgentFkColumn into dev
pull from: 7202-AddCustomAgentFkColumn
merge into: verdnatura:dev
Conversation 1 Commits 13 Files Changed 7 +113 -70
jon commented 2024-09-30 07:18:09 +00:00
Member
Copy Link
No description provided.
jon added 1 commit 2024-09-30 07:18:09 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
6fbc5a1a54 feat: refs #7202 added new field
jon added 1 commit 2024-09-30 07:21:19 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
da749a5dcb fix: refs #7202 fixed sql
jon added 1 commit 2024-09-30 07:46:02 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
451e3bebef fix: refs #7202 fixed back test
jon added 1 commit 2024-09-30 07:47:31 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
5d4b79e313 Merge branch 'dev' into 7202-AddCustomAgentFkColumn
jon requested review from alexm 2024-09-30 07:47:38 +00:00
alexm requested changes 2024-09-30 08:27:11 +00:00
Dismissed
alexm left a comment
Member
Copy Link

FAlta la part de la tarea:
"en el momento de facturar se debe rellenar con el address del cliente (revisar /closeAll, y /invoiceTicketsAndPdf)"

FAlta la part de la tarea: "en el momento de facturar se debe rellenar con el address del cliente (revisar /closeAll, y /invoiceTicketsAndPdf)"
db/dump/fixtures.before.sql Outdated
@ -426,3 +426,3 @@
INSERT INTO `vn`.`address`(`id`, `nickname`, `street`, `city`, `postalCode`, `provinceFk`, `phone`, `mobile`, `isActive`, `clientFk`, `agencyModeFk`, `longitude`, `latitude`, `isEqualizated`, `isDefaultAddress`)
INSERT INTO `vn`.`address`(`id`, `nickname`, `street`, `city`, `postalCode`, `provinceFk`, `phone`, `mobile`, `isActive`, `clientFk`, `agencyModeFk`, `longitude`, `latitude`, `isEqualizated`, `isDefaultAddress`, `customsAgentFk`)
alexm commented 2024-09-30 08:25:48 +00:00
Member
Copy Link

En address?

En address?
jon marked this conversation as resolved
jon added 3 commits 2024-10-01 08:40:06 +00:00
jon added 1 commit 2024-10-01 10:49:03 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
e91386dc92 Merge branch 'dev' into 7202-AddCustomAgentFkColumn
jon requested review from alexm 2024-10-01 10:52:47 +00:00
alexm approved these changes 2024-10-16 07:42:13 +00:00
alexm requested review from carlosap 2024-10-16 07:42:17 +00:00
carlosap requested changes 2024-10-17 08:59:37 +00:00
Dismissed
db/routines/vn/procedures/invoiceOut_new.sql Outdated
@ -123,1 +122,3 @@
WHERE id = vClientFk;
vCplusStandardInvoiceTypeFk)),
a.customsAgentFk
FROM client c
carlosap commented 2024-10-17 08:57:05 +00:00
Member
Copy Link

no de debe de coger del defaultAddressFk del cliente, se debería de coger del addres de los tickets a facturar

no de debe de coger del defaultAddressFk del cliente, se debería de coger del addres de los tickets a facturar
db/routines/vn/procedures/invoiceOut_new.sql Outdated
@ -124,3 +126,4 @@
WHERE c.id = vClientFk;
SET vNewInvoiceId = LAST_INSERT_ID();
carlosap commented 2024-10-17 08:59:30 +00:00
Member
Copy Link

Si se va a guardar el customsAgentFk en la factura se deben de cambiar las consultas de los informes(report) de facturas

Si se va a guardar el customsAgentFk en la factura se deben de cambiar las consultas de los informes(report) de facturas
jon added 4 commits 2024-10-23 06:10:09 +00:00
jon commented 2024-10-23 06:22:13 +00:00
Author
Member
Copy Link

Captura tests back:
image

Captura tests e2e:
image

Captura tests back: ![image](/attachments/c313b7a6-c187-4323-a797-1accb35fa824) Captura tests e2e: ![image](/attachments/2b51a21b-4afe-46ab-bdbb-8a1057c258e0)
image.png
24 KiB
image.png
23 KiB
jon added the
CR / Tests passed
 label 2024-10-23 06:22:21 +00:00
jon requested review from carlosap 2024-10-24 10:37:48 +00:00
jon added 1 commit 2024-10-24 10:37:56 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
2c0f596175 Merge branch 'dev' into 7202-AddCustomAgentFkColumn
carlosap approved these changes 2024-11-12 16:14:20 +00:00
All checks were successful
gitea/salix/pipeline/pr-dev This commit looks good
Required
Details
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
Sign in to join this conversation.
Reviewers
No reviewers
alexm
carlosap
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#3034
No description provided.
Delete Branch "7202-AddCustomAgentFkColumn"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?