verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

fix: refs #7404 add rounding to volume detail #3035

Merged
pablone merged 8 commits from 7404-roundDetailVolume into dev 2024-10-04 05:31:34 +00:00
Conversation 0 Commits 8 Files Changed 4 +14 -8
pablone commented 2024-09-30 08:17:10 +00:00
Member
Copy Link
No description provided.
pablone added 1 commit 2024-09-30 08:17:10 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
e7d07e496e fix: refs #7404 add rounding to volume detail
pablone requested review from jsegarra 2024-09-30 08:17:19 +00:00
pablone added 1 commit 2024-09-30 08:17:25 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
751c0ee39e Merge branch 'dev' into 7404-roundDetailVolume
jsegarra approved these changes 2024-09-30 10:52:42 +00:00
Dismissed
pablone added 1 commit 2024-10-03 07:55:53 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
616c328681 Merge branch 'dev' into 7404-roundDetailVolume
pablone added 1 commit 2024-10-03 10:08:29 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
3f325d865f fix: refs #7404 test for lasEntriesFilter
pablone added 1 commit 2024-10-03 10:08:46 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
02f74e4215 Merge branch 'dev' into 7404-roundDetailVolume
jsegarra requested changes 2024-10-03 10:16:29 +00:00
Dismissed
modules/item/back/methods/item/specs/lastEntriesFilter.spec.js
@ -1,6 +1,6 @@
const {models} = require('vn-loopback/server/server');
describe('item lastEntriesFilter()', () => {
it('should return one entry for the given item', async() => {
it('should return two entry for the given item', async() => {
jsegarra commented 2024-10-03 10:16:25 +00:00
Member
Copy Link

Es correcto este planteamiento, de modificar las cantidades?
Me suena que en la ulktima reunion de Salix, comentamos de obtener los registros antes y evaluar. O este caso no aplica?

Es correcto este planteamiento, de modificar las cantidades? Me suena que en la ulktima reunion de Salix, comentamos de obtener los registros antes y evaluar. O este caso no aplica?
pablone commented 2024-10-03 12:24:31 +00:00
Author
Member
Copy Link

En este casoa no aplica porque en si es un filter la funcionalidad es sacar datos y duplicar codigo tampoco, es el mal menor

En este casoa no aplica porque en si es un filter la funcionalidad es sacar datos y duplicar codigo tampoco, es el mal menor
pablone requested review from jsegarra 2024-10-03 12:24:36 +00:00
jsegarra approved these changes 2024-10-03 12:39:32 +00:00
Dismissed
pablone added 1 commit 2024-10-03 12:40:03 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
46e2ffd6c2 fix: refs #7404 add fixtures
jsegarra approved these changes 2024-10-03 12:40:55 +00:00
pablone added 1 commit 2024-10-04 05:20:16 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
229d5369a1 fix: refs #7404 spec for new entry fixture
pablone added 1 commit 2024-10-04 05:22:09 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
f019214002 Merge branch 'dev' into 7404-roundDetailVolume
pablone merged commit c01e5aee27 into dev 2024-10-04 05:31:34 +00:00
pablone deleted branch 7404-roundDetailVolume 2024-10-04 05:31:34 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jsegarra
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#3035
No description provided.
Delete Branch "7404-roundDetailVolume"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?