verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

8069-Overstocking #3051

Merged
pako merged 7 commits from 8069-Overstocking into dev 2024-10-02 12:34:14 +00:00
Conversation 0 Commits 7 Files Changed 4 +80
pako commented 2024-10-02 06:53:27 +00:00
Member
Copy Link
No description provided.
pako added 4 commits 2024-10-02 06:53:27 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
9d84c39fce feat: refs #8069 orderRow_updateOverstocking
pako requested review from jgallego 2024-10-02 06:53:37 +00:00
pako added 1 commit 2024-10-02 06:53:46 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
b53f6d4008 Merge branch 'dev' into 8069-Overstocking
jgallego requested changes 2024-10-02 07:12:11 +00:00
Dismissed
db/routines/hedera/procedures/orderRow_updateOverstocking.sql Outdated
@ -0,0 +14,4 @@
DECLARE cWarehouses CURSOR FOR
SELECT DISTINCT warehouseFk, shipment
FROM orderRow r
jgallego commented 2024-10-02 07:06:18 +00:00
Owner
Copy Link

sols una taula no cal alias

sols una taula no cal alias
jgallego marked this conversation as resolved
db/routines/hedera/procedures/orderRow_updateOverstocking.sql
@ -0,0 +43,4 @@
JOIN cache.available a ON a.calc_id = vCalcFk AND a.item_id = r.itemFk
SET r.amount = 0
WHERE ADDTIME(o.rowUpdated, oc.reserveTime) < NOW()
AND a.available <= 0
jgallego commented 2024-10-02 07:07:29 +00:00
Owner
Copy Link

cal pensar, si hi ha 20 disponibles, pero el client demana 100?

cal pensar, si hi ha 20 disponibles, pero el client demana 100?
pako commented 2024-10-02 08:21:55 +00:00
Author
Member
Copy Link

a.available <= 0 soluciona el tema. Quan la cistella de la compra està fora de hora, eixa quantitat no s'ha tingut en compte en el càlcul del disponible

a.available <= 0 soluciona el tema. Quan la cistella de la compra està fora de hora, eixa quantitat no s'ha tingut en compte en el càlcul del disponible
pako marked this conversation as resolved
db/routines/hedera/procedures/order_confirmWithUser.sql Outdated
@ -101,6 +101,8 @@ BEGIN
CALL order_checkEditable(vSelf);
CALL orderRow_updateOverstocking(vSelf);
jgallego commented 2024-10-02 07:11:35 +00:00
Owner
Copy Link

es confirmen moltisim pedidos al dia, pero la cache no es calcula tantes vegades, este enfoque colocaria molta carrega, faria les mateixes comprobacions practicamente cada minut varies vegades.
Quan parlarem diguerem de asociar-ho al calcul del disponible

es confirmen moltisim pedidos al dia, pero la cache no es calcula tantes vegades, este enfoque colocaria molta carrega, faria les mateixes comprobacions practicamente cada minut varies vegades. Quan parlarem diguerem de asociar-ho al calcul del disponible
pako commented 2024-10-02 08:24:03 +00:00
Author
Member
Copy Link

Si ho fique en available_refresh, estic cridant desde el esquema hedera al esquema order

I si per eixemple, algú a mà coloca una quantitat gran en una linea de pedido, al recalcular el dispo, borraría moltes cistelles. Després, si modifica la quantitat, les cistelles no tornen al lloc. Per això semblava millor que en el moment de confirmar, faça la cridà.

Si ho fique en available_refresh, estic cridant desde el esquema hedera al esquema order I si per eixemple, algú a mà coloca una quantitat gran en una linea de pedido, al recalcular el dispo, borraría moltes cistelles. Després, si modifica la quantitat, les cistelles no tornen al lloc. Per això semblava millor que en el moment de confirmar, faça la cridà.
jgallego marked this conversation as resolved
pako added 1 commit 2024-10-02 12:04:01 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
fc1ea280fa fix: refs #8069 new conception
pako requested review from jgallego 2024-10-02 12:04:46 +00:00
jgallego approved these changes 2024-10-02 12:26:11 +00:00
pako changed title from WIP: 8069-Overstocking to 8069-Overstocking 2024-10-02 12:32:46 +00:00
pako added 1 commit 2024-10-02 12:32:47 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
abb39ec0e7 Merge branch 'dev' into 8069-Overstocking
pako scheduled this pull request to auto merge when all checks succeed 2024-10-02 12:33:01 +00:00
pako merged commit 3a5eb00a45 into dev 2024-10-02 12:34:14 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#3051
No description provided.
Delete Branch "8069-Overstocking"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?