verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

fix: refs #6861 duplicatedTicketsInReserve #3053

Merged
sergiodt merged 3 commits from 6861-itemShelvingSaleDelete into master 2024-10-08 05:41:56 +00:00
Conversation 1 Commits 3 Files Changed 2 +55 -6
sergiodt commented 2024-10-02 07:57:08 +00:00
Member
Copy Link
No description provided.
sergiodt added 1 commit 2024-10-02 07:57:08 +00:00
gitea/salix/pipeline/pr-master There was a failure building this commit Details
bbcf71619c fix: refs #6861 duplicatedTicketsInReserve
sergiodt requested review from carlosap 2024-10-02 07:57:34 +00:00
sergiodt commented 2024-10-02 07:59:38 +00:00
Author
Member
Copy Link

Consultat en Santi i ok per a poder borrar que estiguen desmacades abans. Provat i OK

Consultat en Santi i ok per a poder borrar que estiguen desmacades abans. Provat i OK
juan requested changes 2024-10-03 14:54:48 +00:00
Dismissed
db/routines/vn/procedures/itemShelvingSale_addBySale copy.sql Outdated
@ -0,0 +15,4 @@
BEGIN
ROLLBACK;
RESIGNAL;
END;
juan commented 2024-10-03 14:54:39 +00:00
Owner
Copy Link

Sobra una tabulación de BEGIN a END.

Sobra una tabulación de `BEGIN` a `END`.
sergiodt marked this conversation as resolved
db/routines/vn/procedures/itemShelvingSale_addBySale copy.sql Outdated
@ -0,0 +20,4 @@
SELECT iss.saleFk INTO vSaleFk
FROM itemShelvingSale iss
JOIN sale s ON s.id = iss.saleFk
WHERE iss.id = vSelf AND s.isAdded ;
juan commented 2024-10-03 14:53:54 +00:00
Owner
Copy Link
  • Mover START TRANSACTION antes del SELECT
  • Añadir FOR UPDATE
  • Quitar espacio antes de punto y coma
- Mover `START TRANSACTION` antes del `SELECT` - Añadir `FOR UPDATE` - Quitar espacio antes de punto y coma
sergiodt marked this conversation as resolved
db/routines/vn/procedures/itemShelvingSale_addBySale copy.sql Outdated
@ -0,0 +31,4 @@
WHERE saleFk = vSaleFk AND isPicked;
IF vHasSalesPicked THEN
CALL util.throw('The sale can not be deleted with sales picked');
juan commented 2024-10-03 14:54:15 +00:00
Owner
Copy Link

A sale with picked sales cannot be deleted

_A sale with picked sales cannot be deleted_
sergiodt marked this conversation as resolved
sergiodt added 1 commit 2024-10-04 08:42:46 +00:00
gitea/salix/pipeline/pr-master This commit looks good Details
324875ec1f fix: refs #6861 deleteAdded
sergiodt requested review from juan 2024-10-04 08:44:58 +00:00
carlosap added 1 commit 2024-10-04 11:07:57 +00:00
gitea/salix/pipeline/pr-master This commit looks good Details
5d7d9f8d9e fix: refs #6861 deleteAdded
carlosap refused to review 2024-10-04 11:09:01 +00:00
juan approved these changes 2024-10-07 07:58:37 +00:00
sergiodt merged commit 4894cb140e into master 2024-10-08 05:41:56 +00:00
sergiodt deleted branch 6861-itemShelvingSaleDelete 2024-10-08 05:41:56 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
juan
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#3053
No description provided.
Delete Branch "6861-itemShelvingSaleDelete"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?