verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

refactor: refs #6824 Throw for no delete itemShelving with itemShelvingSale #3057

Merged
guillermo merged 9 commits from 6824-itemShelvingSaleNoDelete into dev 2024-10-07 05:50:49 +00:00
Conversation 0 Commits 9 Files Changed 4 +16 -1
guillermo commented 2024-10-02 09:27:23 +00:00
Member
Copy Link
No description provided.
guillermo added 1 commit 2024-10-02 09:27:24 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
62bd2ae03b refactor: refs #6824 Throw for no delete itemShelving with itemShelvingSale
guillermo added 1 commit 2024-10-02 09:27:59 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
c4c08934a7 Merge branch 'dev' into 6824-itemShelvingSaleNoDelete
guillermo added 2 commits 2024-10-02 09:32:26 +00:00
guillermo added 1 commit 2024-10-06 08:20:39 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
ba9d0743b5 refactor: refs #6824 Throw for no delete itemShelving with itemShelvingSale
guillermo requested review from jgallego 2024-10-06 08:20:41 +00:00
guillermo added 1 commit 2024-10-06 08:21:10 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
9a327a1c39 Merge branch 'dev' into 6824-itemShelvingSaleNoDelete
guillermo added 2 commits 2024-10-06 08:54:56 +00:00
jgallego requested changes 2024-10-07 05:18:12 +00:00
Dismissed
db/routines/vn/triggers/itemShelving_beforeDelete.sql Outdated
@ -15,0 +5,4 @@
BEGIN
DECLARE vItemShelvingSaleExists BOOL;
SELECT COUNT(*) INTO vItemShelvingSaleExists
jgallego commented 2024-10-07 05:12:18 +00:00
Owner
Copy Link

itemShelvingSale esta es la part que no cal fer, sino canviar en itemShelvingSale a un Fk restrict

itemShelvingSale esta es la part que no cal fer, sino canviar en itemShelvingSale a un Fk restrict
guillermo marked this conversation as resolved
modules/item/back/methods/item-shelving/deleteItemShelvings.js
@ -34,6 +34,11 @@ module.exports = Self => {
try {
const promises = [];
for (let itemShelvingId of itemShelvingIds) {
const itemShelvingSaleToDelete = models.ItemShelvingSale.destroyAll({
jgallego commented 2024-10-07 05:17:23 +00:00
Owner
Copy Link

açò quina part del redmine es? perque si el itemShelving te sales, no es vol que se puguen borrar.

açò quina part del redmine es? perque si el itemShelving te sales, no es vol que se puguen borrar.
guillermo commented 2024-10-07 05:30:23 +00:00
Author
Member
Copy Link

Aixo ho faig en els tests intenta eliminar un itemShelving que conte itemShelvingSale, per lo tant, primer tinc que carregarme els itemShelvingSale i despres els itemShelvings, si no els tests fallen.

Aixo ho faig en els tests intenta eliminar un itemShelving que conte itemShelvingSale, per lo tant, primer tinc que carregarme els itemShelvingSale i despres els itemShelvings, si no els tests fallen.
guillermo added 1 commit 2024-10-07 05:30:41 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
7b4d15cb23 refactor: refs #6824 Requested changes
guillermo requested review from jgallego 2024-10-07 05:30:43 +00:00
jgallego approved these changes 2024-10-07 05:49:46 +00:00
guillermo merged commit 701b8d3c14 into dev 2024-10-07 05:50:49 +00:00
guillermo deleted branch 6824-itemShelvingSaleNoDelete 2024-10-07 05:50:49 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#3057
No description provided.
Delete Branch "6824-itemShelvingSaleNoDelete"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?