verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

#7346 - manualInvoice #3060

Merged
jgallego merged 2 commits from 7346-manualInvoice into dev 2024-10-03 05:45:10 +00:00
Conversation 0 Commits 2 Files Changed 3 +209 -148
jgallego commented 2024-10-02 13:35:38 +00:00
Owner
Copy Link
No description provided.
jgallego added 2 commits 2024-10-02 13:35:38 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
ee52c8b45f fix: refs #7346 findByid con fields
jgallego requested review from alexm 2024-10-02 13:35:43 +00:00
alexm changed title from 7346-manualInvoice to #7346 - manualInvoice 2024-10-02 13:50:20 +00:00
alexm reviewed 2024-10-02 13:55:31 +00:00
modules/invoiceOut/back/methods/invoiceOut/createManualInvoice.js
@ -53,1 +55,3 @@
let tx;
Self.createManualInvoice =
async(ctx, clientFk, addressFk, ticketFk, maxShipped, serial, taxArea, reference, options) => {
if (!clientFk && !ticketFk) throw new UserError(`Select ticket or client`);
alexm commented 2024-10-02 13:55:31 +00:00
Member
Copy Link

Se li pot pasar address sense clientFk?

Se li pot pasar address sense clientFk?
jgallego commented 2024-10-03 05:45:00 +00:00
Author
Owner
Copy Link

No, pero tant si es pasa buit com si es pasa un que no correspon te una validació posterior.

No, pero tant si es pasa buit com si es pasa un que no correspon te una validació posterior.
alexm approved these changes 2024-10-02 13:55:33 +00:00
jgallego merged commit 91d9a6e417 into dev 2024-10-03 05:45:10 +00:00
jgallego deleted branch 7346-manualInvoice 2024-10-03 05:45:10 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexm
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#3060
No description provided.
Delete Branch "7346-manualInvoice"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?