verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

#7919 delete if ticketRefund #3091

Merged
jorgep merged 9 commits from 7919-deleteTicketRefund into dev 2024-10-21 11:21:34 +00:00
Conversation 0 Commits 9 Files Changed 2 +26 -1
jorgep commented 2024-10-10 14:30:29 +00:00
Member
Copy Link
No description provided.
jorgep added 1 commit 2024-10-10 14:30:30 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
770c604d6b chore: refs #7919 delete if ticketRefund
jorgep changed title from chore: refs #7919 delete if ticketRefund to WIP: #7919 delete if ticketRefund 2024-10-10 14:30:42 +00:00
jorgep added 1 commit 2024-10-14 14:49:18 +00:00
jorgep changed title from WIP: #7919 delete if ticketRefund to #7919 delete if ticketRefund 2024-10-14 15:00:59 +00:00
jorgep added 1 commit 2024-10-14 15:11:28 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
ccf9dbde8e feat: refs #7919 test
jorgep added 2 commits 2024-10-14 15:14:45 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
6d4c71d465 feat: refs #7919 test
jorgep requested review from carlosap 2024-10-14 15:20:34 +00:00
jorgep added the
CR / Tests passed
 label 2024-10-14 15:28:27 +00:00
jorgep added 1 commit 2024-10-15 15:01:35 +00:00
jorgep added 1 commit 2024-10-15 15:24:18 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
d57f4fc44a chore: refs #7919 refactor, drop relation on back
jorgep reviewed 2024-10-15 15:27:49 +00:00
modules/ticket/back/methods/ticket/setDeleted.js Outdated
@ -52,3 +54,3 @@
const allDeleted = ticketRefunds.every(refund => refund.refundTicket().isDeleted);
if (ticketRefunds?.length && !allDeleted) {
if (!isRefund) await models.TicketRefund.destroyAll({refundTicketFk: id}, myOptions);
jorgep commented 2024-10-15 15:27:49 +00:00
Author
Member
Copy Link

Si no es originalTicket entrará en el if y solo si existe en la tabla ticketRefund como refundTicket lo eliminará.

Si no es originalTicket entrará en el if y solo si existe en la tabla ticketRefund como refundTicket lo eliminará.
jorgep added 1 commit 2024-10-16 07:23:47 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
8ca097d4a9 chore: refs #7919 change var name
carlosap approved these changes 2024-10-16 14:09:12 +00:00
carlosap requested review from alexm 2024-10-16 14:09:18 +00:00
alexm approved these changes 2024-10-21 10:54:44 +00:00
jorgep added 1 commit 2024-10-21 11:00:34 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
2f77359892 Merge branch 'dev' into 7919-deleteTicketRefund
jorgep merged commit b76b1c6d50 into dev 2024-10-21 11:21:34 +00:00
jorgep deleted branch 7919-deleteTicketRefund 2024-10-21 11:21:35 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
carlosap
alexm
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#3091
No description provided.
Delete Branch "7919-deleteTicketRefund"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?