verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

#7709 -supplierPackaging_ReportSource_2 #3107

Open
robert wants to merge 19 commits from 7709-supplierPackaging_ReportSource_2 into dev
pull from: 7709-supplierPackaging_ReportSource_2
merge into: verdnatura:dev
Conversation 0 Commits 19 Files Changed 1 +138 -127
robert commented 2024-10-16 06:13:37 +00:00
Member
Copy Link
No description provided.
robert added 13 commits 2024-10-16 06:13:38 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
f1dfd515e8 feat: refs #7709 supplierPackaging_ReportSource
gitea/salix/pipeline/pr-dev This commit looks good Details
55fe9f2f86 feat: refs #7709 añadir alias
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
a99fed2690 feat: refs #7709 supplierPackaging_ReportSource
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
46a089cf8e Merge branch 'dev' into 7709-supplierPackaging_ReportSource
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
3f82205206 Merge branch 'dev' into 7709-supplierPackaging_ReportSource
robert changed title from 7709-supplierPackaging_ReportSource_2 to #7709 -supplierPackaging_ReportSource_2 2024-10-16 06:19:14 +00:00
robert requested review from carlosap 2024-10-16 06:19:30 +00:00
carlosap requested changes 2024-10-17 09:04:54 +00:00
db/routines/vn/procedures/supplierPackaging_ReportSource.sql Outdated
@ -10,158 +10,169 @@ BEGIN
* @param vFromDated Starting date
carlosap commented 2024-10-17 08:53:01 +00:00
Member
Copy Link

espacios en los comentarios *

espacios en los comentarios _*_
robert marked this conversation as resolved
db/routines/vn/procedures/supplierPackaging_ReportSource.sql Outdated
@ -14,1 +13,3 @@
SET @vItemFk = NULL;
DECLARE vUser INT;
SELECT id INTO vUser
carlosap commented 2024-10-17 09:02:59 +00:00
Member
Copy Link

los supplier no son users

los supplier no son users
robert marked this conversation as resolved
db/routines/vn/procedures/supplierPackaging_ReportSource.sql
@ -72,2 +37,2 @@
t.cmrFk,
s.price * (100 - s.discount) / 100
t.cmrFk sref,
s.price * (100 - s.discount) / 100 buyingValue
carlosap commented 2024-10-17 09:01:15 +00:00
Member
Copy Link

hay una columna virtual para este valor, es sale

hay una columna virtual para este valor, es sale
robert commented 2024-10-18 05:50:04 +00:00
Author
Member
Copy Link

la columna total de sale el calculo que hace es el siguiente :
(price * quantity * (100 - discount) / 100)

la columna total de sale el calculo que hace es el siguiente : (`price` * `quantity` * (100 - `discount`) / 100)
carlosap marked this conversation as resolved
db/routines/vn/procedures/supplierPackaging_ReportSource.sql Outdated
@ -152,0 +154,4 @@
GROUP BY itemFk
ORDER BY itemFk , landed, entryFk
) sub
WHERE (`out` OR `in`);
carlosap commented 2024-10-17 09:04:08 +00:00
Member
Copy Link

paréntesis innecesarios

paréntesis innecesarios
robert marked this conversation as resolved
db/routines/vn/procedures/supplierPackaging_ReportSource.sql Outdated
@ -162,2 +171,3 @@
CAST(SUM(IF(`in`=0, -`out`, `in`)) OVER (PARTITION BY itemFk ORDER BY itemFk , landed, entryFk) AS DECIMAL(10,2)) balance
FROM tSupplierPackaging
WHERE NOT (NOT balance AND landed < CURDATE() - INTERVAL 1 YEAR);
WHERE NOT (landed < CURDATE() - INTERVAL 1 YEAR)
carlosap commented 2024-10-17 09:03:33 +00:00
Member
Copy Link

no hacer uso de curdate

no hacer uso de curdate
robert marked this conversation as resolved
robert added 1 commit 2024-10-18 05:49:17 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
980b7aa2cc feat: refs #7709 cambios solicitados
carlosap requested review from juan 2024-10-18 07:58:51 +00:00
carlosap requested changes 2024-10-18 08:06:32 +00:00
db/routines/vn/procedures/supplierPackaging_ReportSource.sql Outdated
@ -15,0 +10,4 @@
* @param vFromDated Starting date
* @param vSupplierFk Supplier ID
*/
DECLARE vPerson INT;
carlosap commented 2024-10-18 08:05:54 +00:00
Member
Copy Link

vPerson no és correcte, les empreses no son persones

vClientOrSupplierId
vEntityId

vPerson no és correcte, les empreses no son persones vClientOrSupplierId vEntityId
robert marked this conversation as resolved
robert added 1 commit 2024-10-18 08:34:59 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
e4cd290027 feat: refs #7709 modifcar vPerson por vEntityId
robert requested review from carlosap 2024-10-23 10:29:01 +00:00
robert added 1 commit 2024-10-25 05:08:23 +00:00
robert added 1 commit 2024-11-11 07:02:39 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
46e31b2658 Merge branch 'dev' into 7709-supplierPackaging_ReportSource_2
robert added 1 commit 2024-11-12 06:30:22 +00:00
carlosap refused to review 2024-11-12 16:18:55 +00:00
robert added 1 commit 2024-11-22 05:38:02 +00:00
All checks were successful
gitea/salix/pipeline/pr-dev This commit looks good
Required
Details
This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
Sign in to join this conversation.
Reviewers
No reviewers
juan
carlosap
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#3107
No description provided.
Delete Branch "7709-supplierPackaging_ReportSource_2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?