fix: refs #7906 remake method #3109

Merged
carlossa merged 8 commits from 7906-notDeleteZone into dev 2024-10-18 08:33:04 +00:00
Member
No description provided.
carlossa added 1 commit 2024-10-16 06:35:02 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
46e657675b
fix: refs #7906 remake method
carlossa added 1 commit 2024-10-16 07:30:46 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
c5aa7dc44e
fix: refs #7906 edit test
carlossa changed title from WIP: fix: refs #7906 remake method to fix: refs #7906 remake method 2024-10-16 07:44:07 +00:00
carlossa added the
CR / Tests passed
label 2024-10-16 07:53:05 +00:00
carlossa requested review from alexm 2024-10-16 07:53:15 +00:00
alexm requested changes 2024-10-16 08:48:51 +00:00
Dismissed
@ -61,2 +61,4 @@
if (ticketList.length > 0)
throw new UserError('There are tickets for this area, delete them first');
for (ticket of ticketList) {
Member

Pero si no se vol que se puga si te tickets, ja no cal mirar els tickets no?

Pero si no se vol que se puga si te tickets, ja no cal mirar els tickets no?
carlossa marked this conversation as resolved
carlossa added 1 commit 2024-10-16 09:36:57 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
a282170016
fix: refs #7906 fix method
carlossa requested review from alexm 2024-10-16 10:06:23 +00:00
alexm requested changes 2024-10-16 11:31:46 +00:00
Dismissed
@ -52,22 +53,10 @@ module.exports = Self => {
const promises = [];
Member

Quitar

Quitar
carlossa marked this conversation as resolved
@ -68,4 +60,1 @@
}, myOptions));
}
}
await Promise.all(promises);
Member

Quitar

Quitar
carlossa marked this conversation as resolved
carlossa added 1 commit 2024-10-16 11:56:52 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
3f3b936255
fix: refs #7906 remove code
carlossa requested review from alexm 2024-10-16 11:57:05 +00:00
alexm approved these changes 2024-10-18 05:52:22 +00:00
Dismissed
alexm requested changes 2024-10-18 05:52:53 +00:00
Dismissed
@ -8,7 +8,7 @@ describe('zone deletezone()', () => {
__: value => value
};
Member

Fica un test q prove el nou error "here are tickets for this area, delete them first"

Fica un test q prove el nou error "here are tickets for this area, delete them first"
carlossa added 1 commit 2024-10-18 06:28:17 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
02dc952024
fix: refs #7906 add test
carlossa requested review from alexm 2024-10-18 06:31:44 +00:00
alexm requested changes 2024-10-18 06:42:22 +00:00
Dismissed
@ -57,0 +52,4 @@
const options = {transaction: tx};
await models.Zone.deleteZone(ctx, zoneId2, options);
expect(e.message).toEqual('There are tickets for this area, delete them first');
Member

Fijat be

Fijat be
carlossa marked this conversation as resolved
carlossa added 1 commit 2024-10-18 07:27:52 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
1273e895af
fix: refs #7906 fix test back
carlossa requested review from alexm 2024-10-18 07:28:12 +00:00
alexm approved these changes 2024-10-18 07:29:01 +00:00
carlossa added 1 commit 2024-10-18 07:40:06 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
5a14aed73a
Merge branch 'dev' into 7906-notDeleteZone
carlossa added 1 commit 2024-10-18 08:31:40 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
ed69604767
Merge branch 'dev' into 7906-notDeleteZone
carlossa merged commit a5bbdd7a01 into dev 2024-10-18 08:33:04 +00:00
carlossa deleted branch 7906-notDeleteZone 2024-10-18 08:33:04 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#3109
No description provided.