verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

refactor: refs #8106 Optimized ticket_getTax #3122

Merged
guillermo merged 2 commits from 8106-negativeBasesOptimize into dev 2024-10-18 08:27:09 +00:00
Conversation 0 Commits 2 Files Changed 2 +42 -31
guillermo commented 2024-10-17 12:46:48 +00:00
Member
Copy Link
No description provided.
guillermo added 1 commit 2024-10-17 12:46:49 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
28e957fecd refactor: refs #8106 refs #1406 Optimized ticket_getTax
guillermo requested review from carlosap 2024-10-17 12:46:53 +00:00
guillermo changed title from refactor: refs #8106 refs #1406 Optimized ticket_getTax to refactor: refs #8106 Optimized ticket_getTax 2024-10-17 12:47:48 +00:00
carlosap requested changes 2024-10-17 15:47:39 +00:00
Dismissed
db/routines/vn/procedures/ticket_getTax.sql Outdated
@ -36,2 +38,2 @@
SELECT * FROM (
SELECT tmpTicket.ticketFk,
WITH sales AS (
SELECT s.id,
carlosap commented 2024-10-17 14:39:18 +00:00
Member
Copy Link

los campos s.id y s.ticketFk no son necesarios en la primera SELECT

los campos s.id y s.ticketFk no son necesarios en la primera SELECT
guillermo commented 2024-10-18 05:10:55 +00:00
Author
Member
Copy Link

El s.id ok, pero el s.ticketFk sí es necesario, ya que se utiliza en el GROUP BY

El s.id ok, pero el s.ticketFk sí es necesario, ya que se utiliza en el GROUP BY
guillermo marked this conversation as resolved
db/routines/vn/procedures/ticket_getTax.sql Outdated
@ -58,2 +72,3 @@
HAVING taxableBase
) t3
)
SELECT *
carlosap commented 2024-10-17 14:47:22 +00:00
Member
Copy Link

Se puede eliminar el alias de la consulta ticketTax, se puede añadir el ORDER BY priority en la consulta superior y así simplificarlo

Se puede eliminar el alias de la consulta ticketTax, se puede añadir el ORDER BY priority en la consulta superior y así simplificarlo
guillermo marked this conversation as resolved
guillermo added 1 commit 2024-10-18 05:15:31 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
865da7bba2 refactor: refs #8106 Requested changes
guillermo requested review from carlosap 2024-10-18 05:15:41 +00:00
carlosap approved these changes 2024-10-18 07:56:25 +00:00
guillermo merged commit 939f083671 into dev 2024-10-18 08:27:09 +00:00
guillermo deleted branch 8106-negativeBasesOptimize 2024-10-18 08:27:09 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
carlosap
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#3122
No description provided.
Delete Branch "8106-negativeBasesOptimize"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?