verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

fix: refs #6850 remove notifyPickUp #3132

Merged
carlossa merged 5 commits from 6850-removeChandgeUpdateClaim into dev 2024-10-21 12:31:32 +00:00
Conversation 0 Commits 5 Files Changed 1 +5 -24
carlossa commented 2024-10-20 14:24:28 +00:00
Member
Copy Link
No description provided.
carlossa added 1 commit 2024-10-20 14:24:29 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
b88dc1c70f fix: refs #6850 remove notifyPickUp
carlossa added 1 commit 2024-10-21 06:30:50 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
19fbb836a6 fix: refs #6850 fix model
carlossa changed title from WIP: fix: refs #6850 remove notifyPickUp to fix: refs #6850 remove notifyPickUp 2024-10-21 06:34:30 +00:00
carlossa requested review from alexm 2024-10-21 06:34:33 +00:00
alexm requested changes 2024-10-21 06:46:33 +00:00
Dismissed
modules/claim/back/methods/claim/updateClaim.js Outdated
@ -86,9 +86,6 @@ module.exports = Self => {
const salesPerson = claim.client().salesPersonUser();
if (salesPerson) {
alexm commented 2024-10-21 06:46:30 +00:00
Member
Copy Link

fica el altre if en un and y ahorres tindre 2 ifs

fica el altre if en un and y ahorres tindre 2 ifs
carlossa marked this conversation as resolved
carlossa added 1 commit 2024-10-21 07:25:19 +00:00
gitea/salix/pipeline/pr-dev Build queued... Details
eea09a9d4a fix: refs #6850 add code
carlossa requested review from alexm 2024-10-21 07:27:44 +00:00
carlossa added 1 commit 2024-10-21 07:27:48 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
bf0cc687e1 Merge branch 'dev' into 6850-removeChandgeUpdateClaim
alexm approved these changes 2024-10-21 11:00:14 +00:00
carlossa added 1 commit 2024-10-21 12:26:57 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
aad616ff83 Merge branch 'dev' into 6850-removeChandgeUpdateClaim
carlossa merged commit 56cba385cf into dev 2024-10-21 12:31:31 +00:00
carlossa deleted branch 6850-removeChandgeUpdateClaim 2024-10-21 12:31:32 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexm
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#3132
No description provided.
Delete Branch "6850-removeChandgeUpdateClaim"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?