verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

fix: refs #235425 sale priceFixed update #3146

Merged
guillermo merged 3 commits from hotfix235425-updatePrice into master 2024-10-28 06:06:58 +00:00
Conversation 0 Commits 3 Files Changed 3 +37 -1
guillermo commented 2024-10-24 10:26:19 +00:00
Member
Copy Link
No description provided.
guillermo added 1 commit 2024-10-24 10:26:19 +00:00
gitea/salix/pipeline/pr-master This commit looks good Details
4da11c65bb fix: refs #235425 sale priceFixed update
guillermo requested review from jgallego 2024-10-24 10:26:46 +00:00
jgallego requested changes 2024-10-24 11:08:55 +00:00
Dismissed
modules/ticket/back/methods/sale/updatePrice.js Outdated
@ -92,6 +92,19 @@ module.exports = Self => {
}, myOptions);
}
await sale.updateAttributes({price: newPrice}, myOptions);
await Self.rawSql(`
jgallego commented 2024-10-24 11:08:52 +00:00
Owner
Copy Link

la idea es bona, hi ha que actualizar el valor, pero posiblement en les dades de dalt ja tingam el valro, i si no, calculal, el poses en
await sale.updateAttributes({price: newPrice}, myOptions);
per a no fer 2 updates en la BBDD ni en el log

la idea es bona, hi ha que actualizar el valor, pero posiblement en les dades de dalt ja tingam el valro, i si no, calculal, el poses en `await sale.updateAttributes({price: newPrice}, myOptions);` per a no fer 2 updates en la BBDD ni en el log
guillermo marked this conversation as resolved
guillermo requested review from jgallego 2024-10-25 05:22:40 +00:00
guillermo added 1 commit 2024-10-25 05:22:43 +00:00
gitea/salix/pipeline/pr-master This commit looks good Details
111480f7b7 fix: refs #235425 Requested changes
jgallego requested changes 2024-10-25 05:33:38 +00:00
Dismissed
modules/ticket/back/methods/sale/updatePrice.js
@ -95,0 +104,4 @@
await sale.updateAttributes({
price: newPrice,
priceFixed: priceFixed.value
jgallego commented 2024-10-25 05:33:29 +00:00
Owner
Copy Link

perfect, cal canviar el test de back per a que també verifique este canvi, simplement verifica que el valor antes i despues de cridar a la funcio son distints (chatgpt) 392c4dcba3

perfect, cal canviar el test de back per a que també verifique este canvi, simplement verifica que el valor antes i despues de cridar a la funcio son distints (chatgpt) https://gitea.verdnatura.es/verdnatura/salix/commit/392c4dcba3b1907b2ef49ee01bb3d17e8ca45811
guillermo marked this conversation as resolved
guillermo added 1 commit 2024-10-25 06:47:47 +00:00
gitea/salix/pipeline/pr-master This commit looks good Details
69e1df2504 fix: refs #235425 Requested changes
guillermo requested review from jgallego 2024-10-25 06:47:57 +00:00
jgallego approved these changes 2024-10-25 13:40:40 +00:00
guillermo merged commit a707f9cbff into master 2024-10-28 06:06:57 +00:00
guillermo deleted branch hotfix235425-updatePrice 2024-10-28 06:06:58 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#3146
No description provided.
Delete Branch "hotfix235425-updatePrice"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?