verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

feat: refs #8087 Traspasar redadas a travels #3147

Merged
carlosap merged 6 commits from 8087-nuevoCampoTravel into dev 2024-10-28 14:41:02 +00:00
Conversation 0 Commits 6 Files Changed 40 +389 -437
carlosap commented 2024-10-24 11:08:51 +00:00
Member
Copy Link
No description provided.
carlosap added 1 commit 2024-10-24 11:08:51 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
1bf900f81b feat: refs #8087 Traspasar redadas a travels
carlosap added 1 commit 2024-10-24 17:32:04 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
4d3bc2c837 feat: refs #8087 Traspasar redadas a travels
carlosap requested review from jgallego 2024-10-25 08:06:37 +00:00
carlosap added 1 commit 2024-10-25 12:34:55 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
fb0764bc1f feat: refs #8087 Traspasar redadas a travels
jgallego requested changes 2024-10-25 12:58:18 +00:00
Dismissed
db/routines/cache/procedures/availableNoRaids_refresh.sql
@ -54,3 +54,3 @@
AND t.warehouseInFk = vWarehouse
AND s.name != 'INVENTARIO'
AND NOT e.isRaid
AND NOT t.daysInForward
jgallego commented 2024-10-25 12:57:59 +00:00
Owner
Copy Link

cuidao!
AND t.daysInForward IS NULL

sols volem els travels que no tenen valor no?
si es així revisa la resta que hi ha mes llocs

cuidao! AND t.daysInForward IS NULL sols volem els travels que no tenen valor no? si es així revisa la resta que hi ha mes llocs
carlosap commented 2024-10-25 14:37:39 +00:00
Author
Member
Copy Link

Per no cambiar tota la lógica de tots els puestos he ficat el valor not NULL default 0.
Era aixó o canviar en tots els puestos on apareix(que no son pocs) pero ( NOT t.daysInForward AND t.daysInForward IS NULL)

Per no cambiar tota la lógica de tots els puestos he ficat el valor not NULL default 0. Era aixó o canviar en tots els puestos on apareix(que no son pocs) pero ( NOT t.daysInForward AND t.daysInForward IS NULL)
jgallego marked this conversation as resolved
carlosap requested review from jgallego 2024-10-25 14:37:44 +00:00
jgallego requested changes 2024-10-25 14:38:51 +00:00
Dismissed
db/routines/hedera/procedures/item_getVisible.sql
@ -60,3 +60,3 @@
WHERE t.landed BETWEEN vDateInv AND vDate
AND t.warehouseInFk = vWarehouse
AND NOT e.isRaid
AND NOT t.daysInForward
jgallego commented 2024-10-25 14:38:43 +00:00
Owner
Copy Link

ací has de pensar que sera null fes alguna prova a vore

ací has de pensar que sera null fes alguna prova a vore
jgallego marked this conversation as resolved
carlosap added 1 commit 2024-10-28 13:02:32 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
61026d2d34 feat: refs #8087 Traspasar redadas a travels
jgallego requested changes 2024-10-28 13:11:12 +00:00
Dismissed
db/versions/11316-chocolateErica/00-firstScript.sql Outdated
@ -0,0 +1,7 @@
ALTER TABLE vn.travel ADD IF NOT EXISTS daysInForward INT UNSIGNED DEFAULT 0 NOT NULL
COMMENT 'Número de días donde se siturá el landed de las entradas con respecto a hoy';
jgallego commented 2024-10-28 13:11:10 +00:00
Owner
Copy Link

poner una descripcion que aparezca la palabra redada

poner una descripcion que aparezca la palabra redada
jgallego commented 2024-10-28 13:30:50 +00:00
Owner
Copy Link

Crec que el comment te un numero de digits asegurat que es guarda tot

Crec que el comment te un numero de digits asegurat que es guarda tot
carlosap added 1 commit 2024-10-28 13:22:13 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
511c848342 feat: refs #8087 Traspasar redadas a travels
carlosap requested review from jgallego 2024-10-28 13:22:51 +00:00
carlosap added 1 commit 2024-10-28 13:24:48 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
bffb13f94a feat: refs #8087 Traspasar redadas a travels
jgallego approved these changes 2024-10-28 13:30:52 +00:00
carlosap merged commit 66a5708efb into dev 2024-10-28 14:41:02 +00:00
carlosap deleted branch 8087-nuevoCampoTravel 2024-10-28 14:41:02 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#3147
No description provided.
Delete Branch "8087-nuevoCampoTravel"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?