verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

feat: refs#8087 Redadas en travel #3177

Merged
carlosap merged 7 commits from 8087-nuevosCamposTravel into dev 2024-11-19 16:57:16 +00:00
Conversation 0 Commits 7 Files Changed 39 +116 -80
carlosap commented 2024-11-11 13:20:50 +00:00
Member
Copy Link
No description provided.
carlosap added 1 commit 2024-11-11 13:20:50 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
cf102699d5 feat: refs#8087 Redadas en travel
carlosap requested review from jgallego 2024-11-11 13:20:58 +00:00
jgallego requested changes 2024-11-11 13:59:55 +00:00
Dismissed
jgallego left a comment
Owner
Copy Link

posa si cal restriccio per a que no puguen posar dies si no es redada..seria incongruent

posa si cal restriccio per a que no puguen posar dies si no es redada..seria incongruent
db/routines/edi/triggers/supplyResponse_afterUpdate.sql
@ -15,3 +15,3 @@
WHERE i.supplyResponseFk = NEW.ID
AND am.name = 'LOGIFLORA'
AND tr.daysInForward
AND tr.isRaid
jgallego commented 2024-11-11 13:56:31 +00:00
Owner
Copy Link

aci no seria NOT?

aci no seria NOT?
carlosap commented 2024-11-12 15:54:54 +00:00
Author
Member
Copy Link

en producció està aixina

en producció està aixina
carlosap marked this conversation as resolved
db/routines/vn/procedures/travel_moveRaids.sql
@ -38,3 +38,3 @@
util.VN_CURDATE() + INTERVAL daysInForward DAY newLanded
FROM travel
WHERE daysInForward;
WHERE isRaid
jgallego commented 2024-11-11 13:57:40 +00:00
Owner
Copy Link

NOT ¿?

NOT ¿?
carlosap commented 2024-11-12 15:55:18 +00:00
Author
Member
Copy Link

Vols moure els de que ron isRaid

Vols moure els de que ron isRaid
carlosap marked this conversation as resolved
db/versions/11332-tealErica/00-firstScript.sql Outdated
@ -0,0 +1,4 @@
ALTER TABLE vn.travel ADD isRaid tinyint(1) DEFAULT 0 NOT NULL COMMENT 'Redada';
ALTER TABLE vn.travel MODIFY COLUMN daysInForward int(10) unsigned DEFAULT NULL
COMMENT 'Cuando es una redada, indica el número de días que se añadirán a la fecha de hoy para establecer el landed';
jgallego commented 2024-11-11 13:59:11 +00:00
Owner
Copy Link

posa null si no es redada per exemple

posa null si no es redada per exemple
carlosap marked this conversation as resolved
carlosap added 1 commit 2024-11-12 15:24:10 +00:00
carlosap added 1 commit 2024-11-12 15:26:33 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
358ed2513d feat: refs#8087 Redadas en travel
carlosap added 1 commit 2024-11-12 15:50:51 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
b8f2e0b906 feat: refs#8087 Redadas en travel
carlosap requested review from jgallego 2024-11-12 15:55:30 +00:00
jgallego approved these changes 2024-11-12 18:05:53 +00:00
Dismissed
carlosap added 1 commit 2024-11-19 12:40:17 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
6a43d3c752 feat: refs#8087 Redadas en travel
carlosap added 1 commit 2024-11-19 12:49:06 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
953bc84a58 feat: refs#8087 Redadas en travel
carlosap added 1 commit 2024-11-19 12:52:16 +00:00
carlosap requested review from jgallego 2024-11-19 12:56:29 +00:00
jgallego approved these changes 2024-11-19 16:34:15 +00:00
carlosap merged commit ad345a0b91 into dev 2024-11-19 16:57:16 +00:00
carlosap deleted branch 8087-nuevosCamposTravel 2024-11-19 16:57:17 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#3177
No description provided.
Delete Branch "8087-nuevosCamposTravel"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?