refactor: refs #7920 Main change #3194

Merged
guillermo merged 9 commits from 7920-itemShelving into dev 2024-11-15 06:44:17 +00:00
Member
No description provided.
guillermo added 1 commit 2024-11-13 06:43:11 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
c2381f0feb
refactor: refs #7920 Main change
guillermo added 1 commit 2024-11-13 08:03:49 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
779a75cd78
refactor: refs #7920 Major changes
guillermo added 1 commit 2024-11-13 08:56:41 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
2273dc636e
refactor: refs #7920 Major changes
guillermo added 1 commit 2024-11-13 10:15:34 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
b3bf0024e3
refactor: refs #7920 Major changes
guillermo added 1 commit 2024-11-13 10:17:00 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
9d5ef3eeb0
Merge branch 'dev' into 7920-itemShelving
guillermo added 1 commit 2024-11-13 10:51:26 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
755312b981
refactor: refs #7920 Fix tests
guillermo added 1 commit 2024-11-13 11:04:52 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
5a134668da
refactor: refs #7920 itemShelvingLog
guillermo changed title from refactor: refs #7920 Main change to WIP: refactor: refs #7920 Main change 2024-11-13 11:07:57 +00:00
guillermo changed title from WIP: refactor: refs #7920 Main change to refactor: refs #7920 Main change 2024-11-13 11:09:12 +00:00
guillermo requested review from jgallego 2024-11-13 11:09:17 +00:00
jgallego requested changes 2024-11-14 07:40:54 +00:00
Dismissed
@ -1,14 +1,14 @@
DELIMITER $$
CREATE OR REPLACE DEFINER=`vn`@`localhost` PROCEDURE `vn`.`itemShelvingLog_get`(vShelvingFk VARCHAR(10) )
CREATE OR REPLACE DEFINER=`vn`@`localhost` PROCEDURE `vn`.`itemShelvingLog_get`(
vShelvingFk VARCHAR(10)
Owner

int? o shelvingCode?

int? o shelvingCode?
Author
Member

ShelvingCode, vuic fer-ho retrocompatible

ShelvingCode, vuic fer-ho retrocompatible
guillermo marked this conversation as resolved
@ -116,0 +112,4 @@
SELECT ish.id, ish.visible INTO vTargetItemShelvingFk, vCurrentVisible
FROM itemShelving ish
JOIN shelving sh ON sh.id = ish.shelvingFk
WHERE sh.code = vShelvingCode COLLATE utf8mb3_general_ci
Owner

si el poses dalt en la definicio no cal que el poses dos vegades en el codi

si el poses dalt en la definicio no cal que el poses dos vegades en el codi
guillermo marked this conversation as resolved
@ -1,11 +1,10 @@
DELIMITER $$
CREATE OR REPLACE DEFINER=`vn`@`localhost` PROCEDURE `vn`.`shelvingChange`(IN `vShelvingO` VARCHAR(8), IN `vShelvingD` VARCHAR(8))
Owner

la taula es varchar10, revisals tots per si de cas

la taula es varchar10, revisals tots per si de cas
guillermo marked this conversation as resolved
@ -27,0 +30,4 @@
}
});
if (!shelving) return [];
Owner

@alexm que es fa en estos casos? perque tornar [] jo no ho he vist

@alexm que es fa en estos casos? perque tornar [] jo no ho he vist
Member

Normalment fem
if (!shelving) return;

Normalment fem `if (!shelving) return;`
Author
Member

Ho vaig provar, i donaba error perque se espera un array..

Ho vaig provar, i donaba error perque se espera un array..
guillermo marked this conversation as resolved
guillermo added 1 commit 2024-11-14 08:59:07 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
d387486ea8
refactor: refs #7920 Requested changes
guillermo requested review from jgallego 2024-11-14 08:59:11 +00:00
jgallego approved these changes 2024-11-14 15:26:16 +00:00
guillermo added 1 commit 2024-11-15 06:40:43 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
48ffb80094
Merge branch 'dev' into 7920-itemShelving
guillermo merged commit 216b81adda into dev 2024-11-15 06:44:17 +00:00
guillermo deleted branch 7920-itemShelving 2024-11-15 06:44:17 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#3194
No description provided.