verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

#7127 modify days when adding lines to a claim #3195

Open
jon wants to merge 1 commits from 7127-ModifyDaysToAddSales into dev
pull from: 7127-ModifyDaysToAddSales
merge into: verdnatura:dev
Conversation 0 Commits 1 Files Changed 6 +42 -22
jon commented 2024-11-13 07:30:54 +00:00
Member
Copy Link
No description provided.
jon added 1 commit 2024-11-13 07:30:55 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
9113f2e3e5 feat: refs #7127 modify days when adding lines to a claim
jon changed title from WIP: #7127 modify days when adding lines to a claim to #7127 modify days when adding lines to a claim 2024-11-13 07:38:03 +00:00
jon requested review from jgallego 2024-11-13 07:38:09 +00:00
jgallego requested changes 2024-11-13 07:48:19 +00:00
modules/claim/back/models/claim-beginning.js
@ -16,2 +20,4 @@
const role = await models.VnRole.findById(user.roleFk);
const sale = await models.Sale.findById(saleFk, {fields: ['ticketFk', 'quantity']}, options);
if (role.name !== 'salesPerson' && role.name !== 'claimManager')
jgallego commented 2024-11-13 07:46:14 +00:00
Owner
Copy Link

esto seria incorrecto.
Los permisos se consultan mirando los acls
ejmplo d1659ce04c/modules/claim/back/methods/claim/createFromSales.js (L64)

esto seria incorrecto. Los permisos se consultan mirando los acls ejmplo https://gitea.verdnatura.es/verdnatura/salix/src/commit/d1659ce04c87ffb7bb531c07de854fd19cd7cf84/modules/claim/back/methods/claim/createFromSales.js#L64
All checks were successful
gitea/salix/pipeline/pr-dev This commit looks good
Required
Details
This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#3195
No description provided.
Delete Branch "7127-ModifyDaysToAddSales"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?