verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

#8002 adjust to Lilium #3199

Open
jorgep wants to merge 8 commits from 8002-refactorToLilium into dev
pull from: 8002-refactorToLilium
merge into: verdnatura:dev
Conversation 0 Commits 8 Files Changed 3 +19 -39
jorgep commented 2024-11-13 12:37:14 +00:00
Member
Copy Link
No description provided.
jorgep added 1 commit 2024-11-13 14:45:48 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
1c49c073ee feat: refs #8002 drop support btn
jorgep added 1 commit 2024-11-13 16:35:58 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
b75b369716 feat: refs #8002 adjust to lilium
jorgep added 1 commit 2024-11-13 16:45:19 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
873b91f113 chore: refs #8002 drop comments
jorgep requested review from alexm 2024-11-13 16:46:34 +00:00
jorgep added the
CR / Tests passed
 label 2024-11-13 16:56:05 +00:00
alexm requested changes 2024-11-14 06:42:48 +00:00
Dismissed
back/methods/osticket/sendToSupport.js Outdated
@ -37,0 +37,4 @@
let html = `<h2>Motivo: ${reason}</h2>`;
html += `<h3>Usuario: ${userId} ${emailUser.email}</h3>`;
html += `<h3>Additional Data:</h3>`;
html += `<ul><li>Code: ${code}</li>`;
alexm commented 2024-11-14 06:41:22 +00:00
Member
Copy Link

no seria millor fer un for in de les keys de additionalData aixina no cal ficarles a ma?

no seria millor fer un for in de les keys de additionalData aixina no cal ficarles a ma?
jorgep marked this conversation as resolved
front/core/components/snackbar/snackbar.js Outdated
@ -29,3 +29,3 @@
if (data.additionalData && this.vnToken.token) {
if (data.additionalData && this.vnToken.token)
this.additionalData = data.additionalData;
alexm commented 2024-11-14 06:42:46 +00:00
Member
Copy Link

Esto ya no hcae falta tampococ no?

Esto ya no hcae falta tampococ no?
jorgep marked this conversation as resolved
jorgep added 3 commits 2024-11-14 09:47:45 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
dbf5953d69 refactor: refs #8002 use loop wip
jorgep added 1 commit 2024-11-14 10:42:35 +00:00
jorgep requested review from alexm 2024-11-14 11:08:29 +00:00
jorgep added 1 commit 2024-11-14 11:29:59 +00:00
alexm approved these changes 2024-11-14 13:05:42 +00:00
All checks were successful
gitea/salix/pipeline/pr-dev This commit looks good
Required
Details
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
Sign in to join this conversation.
Reviewers
No reviewers
alexm
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#3199
No description provided.
Delete Branch "8002-refactorToLilium"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?