verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

feat: refs #8151 moveExpeditions #3200

Merged
guillermo merged 7 commits from 8151-moveExpeditions into dev 2024-11-15 05:59:19 +00:00
Conversation 0 Commits 7 Files Changed 2 +53 -7
guillermo commented 2024-11-13 12:46:49 +00:00
Member
Copy Link
No description provided.
guillermo added 1 commit 2024-11-13 12:46:49 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
344427da45 feat: refs #8151 moveExpeditions
guillermo reviewed 2024-11-13 12:48:05 +00:00
modules/ticket/back/methods/expedition/moveExpeditions.js
@ -82,3 +82,3 @@
}
await Promise.all(promises);
await models.Ticket.updateAll({id: ticket.id}, {packages: promises.length}, myOptions);
guillermo commented 2024-11-13 12:48:05 +00:00
Author
Member
Copy Link

no he utilizado ticket.updateAttribute porque me daba error val.slice is not a function en una linea de código de la libreria sqlstring

no he utilizado ticket.updateAttribute porque me daba `error val.slice is not a function` en una linea de código de la libreria sqlstring
guillermo requested review from jgallego 2024-11-13 12:48:13 +00:00
guillermo added 1 commit 2024-11-13 13:04:05 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
018393fa93 feat: refs #8151 Added test
guillermo added 1 commit 2024-11-13 13:05:06 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
d4a60f63c9 feat: refs #8151 Added test
jgallego requested changes 2024-11-14 07:10:33 +00:00
Dismissed
modules/ticket/back/methods/expedition/specs/moveExpeditions.spec.js
@ -37,0 +51,4 @@
const ticket = await models.Expedition.moveExpeditions(myCtx, options);
const newestTicketIdInFixtures = 27;
jgallego commented 2024-11-14 07:09:42 +00:00
Owner
Copy Link

fes este id relatiu, sino quan creen fixturs trencara este test

fes este id relatiu, sino quan creen fixturs trencara este test
guillermo marked this conversation as resolved
guillermo added 1 commit 2024-11-14 09:45:32 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
534b50f51a feat: refs #8151 Requested changes
guillermo requested review from jgallego 2024-11-14 09:46:02 +00:00
guillermo added 1 commit 2024-11-14 09:46:03 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
b7cb420c72 Merge branch 'dev' into 8151-moveExpeditions
guillermo added 2 commits 2024-11-14 09:53:17 +00:00
jgallego approved these changes 2024-11-14 15:25:08 +00:00
guillermo merged commit 3b48cf3d5d into dev 2024-11-15 05:59:19 +00:00
guillermo deleted branch 8151-moveExpeditions 2024-11-15 05:59:20 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#3200
No description provided.
Delete Branch "8151-moveExpeditions"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?