verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

feat: refs #8057 Added geoFk columns #3204

Merged
guillermo merged 10 commits from 8057-geoFk into dev 2024-11-18 11:47:54 +00:00
Conversation 2 Commits 10 Files Changed 12 +146 -8
guillermo commented 2024-11-14 07:24:58 +00:00
Member
Copy Link
No description provided.
guillermo added 1 commit 2024-11-14 07:24:58 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
b7655b4f92 feat: refs #8057 Added geoFk columns
guillermo added 1 commit 2024-11-14 08:00:28 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
d4b0da50d0 feat: refs #8057 Added data updates
guillermo added 1 commit 2024-11-14 08:27:43 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
cba1abad68 feat: refs #8057 Added data updates
guillermo changed title from feat: refs #8057 Added geoFk columns to WIP: feat: refs #8057 Added geoFk columns 2024-11-14 08:28:30 +00:00
guillermo changed title from WIP: feat: refs #8057 Added geoFk columns to feat: refs #8057 Added geoFk columns 2024-11-14 08:28:44 +00:00
guillermo added 1 commit 2024-11-14 08:30:42 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
bde192966e feat: refs #8057 Added data updates
guillermo added 1 commit 2024-11-14 08:32:07 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
b9397c527d feat: refs #8057 Added data updates
guillermo requested review from jgallego 2024-11-14 08:32:45 +00:00
jgallego approved these changes 2024-11-14 15:21:43 +00:00
jgallego commented 2024-11-14 15:22:32 +00:00
Owner
Copy Link

@pako esta es la tarea que demanares en el redmine https://redmine.verdnatura.es/issues/8057 confirma que la implementació s'ajusta a lo que volies.

@pako esta es la tarea que demanares en el redmine https://redmine.verdnatura.es/issues/8057 confirma que la implementació s'ajusta a lo que volies.
jgallego requested review from pako 2024-11-14 15:22:38 +00:00
pako requested changes 2024-11-18 05:24:31 +00:00
Dismissed
db/routines/vn/functions/client_getGeo.sql Outdated
@ -0,0 +17,4 @@
JOIN postCode p ON p.townFk = t.id
AND p.`code` = c.postcode
WHERE c.id = vSelf
ORDER BY (c.city SOUNDS LIKE t.`name`) DESC
pako commented 2024-11-18 05:19:58 +00:00
Member
Copy Link

Puede ser que el cliente no tenga codigo postal. Yo pondria, en lugar de

AND p.code = c.postcode

en el order by pondria

ORDER BY (c.city SOUNDS LIKE t.name) DESC, (p.code = c.postcode) DESC

Puede ser que el cliente no tenga codigo postal. Yo pondria, en lugar de AND p.`code` = c.postcode en el order by pondria ORDER BY (c.city SOUNDS LIKE t.`name`) DESC, (p.`code` = c.postcode) DESC
guillermo marked this conversation as resolved
db/routines/vn/functions/supplier_getGeo.sql Outdated
@ -0,0 +15,4 @@
FROM supplier s
JOIN town t ON t.provinceFk = s.provinceFk
JOIN postCode p ON p.townFk = t.id
AND p.`code` = s.postCode
pako commented 2024-11-18 05:20:47 +00:00
Member
Copy Link

Lo mismo que el caso anterior. Hay 1637 proveedores sin codigo postal

Lo mismo que el caso anterior. Hay 1637 proveedores sin codigo postal
guillermo marked this conversation as resolved
db/versions/11346-yellowPhormium/00-address.sql
@ -0,0 +9,4 @@
SELECT a.id, p.geoFk
FROM address a
JOIN town t ON t.provinceFk = a.provinceFk
JOIN postCode p ON p.townFk = t.id
pako commented 2024-11-18 05:22:48 +00:00
Member
Copy Link

Lo mismo, pondria la restriccion del postcode en el order by

Lo mismo, pondria la restriccion del postcode en el order by
guillermo marked this conversation as resolved
db/versions/11346-yellowPhormium/02-supplier.sql
@ -0,0 +11,4 @@
SELECT s.id, p.geoFk
FROM supplier s
JOIN town t ON t.provinceFk = s.provinceFk
JOIN postCode p ON p.townFk = t.id
pako commented 2024-11-18 05:24:00 +00:00
Member
Copy Link

Lo mismo de antes

Lo mismo de antes
guillermo marked this conversation as resolved
guillermo added 1 commit 2024-11-18 07:58:42 +00:00
gitea/salix/pipeline/pr-dev Build queued... Details
353ca659cd feat: refs #8057 Requested changes
guillermo requested review from pako 2024-11-18 07:58:46 +00:00
guillermo added 1 commit 2024-11-18 07:58:53 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
e81727f3f8 Merge branch 'dev' into 8057-geoFk
pako commented 2024-11-18 09:41:00 +00:00
Member
Copy Link

No has modificat el codi del final

No has modificat el codi del final
pako requested changes 2024-11-18 09:41:27 +00:00
Dismissed
pako left a comment
Member
Copy Link

No has cambiado el codigo del final

No has cambiado el codigo del final
guillermo added 2 commits 2024-11-18 09:52:47 +00:00
guillermo added 1 commit 2024-11-18 09:52:58 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
66009ee0dd Merge branch 'dev' into 8057-geoFk
guillermo requested review from pako 2024-11-18 09:52:58 +00:00
pako approved these changes 2024-11-18 11:05:19 +00:00
guillermo merged commit baadd621e1 into dev 2024-11-18 11:47:54 +00:00
guillermo deleted branch 8057-geoFk 2024-11-18 11:47:54 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
pako
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#3204
No description provided.
Delete Branch "8057-geoFk"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?