verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

refactor: refs #8210 ticket_splitItemPackingType #3217

Merged
carlosap merged 5 commits from 8210-RefactorTicket_splitItemPackingType into dev 2024-11-21 12:39:35 +00:00
Conversation 0 Commits 5 Files Changed 2 +94 -92
carlosap commented 2024-11-19 10:05:14 +00:00
Member
Copy Link
No description provided.
carlosap added 1 commit 2024-11-19 10:05:14 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
43e121a2f3 refactor: refs #8210 ticket_splitItemPackingType
carlosap requested review from pako 2024-11-19 10:05:21 +00:00
carlosap added 1 commit 2024-11-19 10:07:21 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
a7ab8696ac refactor: refs #8210 ticket_splitItemPackingType
pako requested changes 2024-11-19 11:09:47 +00:00
Dismissed
pako left a comment
Member
Copy Link

Transaccionar.

Sobra el WHERE en la linea 82

Revisar el GROUP BY de la linea 90, posar el COALESCE per a obtindre els not null primer

Transaccionar. Sobra el WHERE en la linea 82 Revisar el GROUP BY de la linea 90, posar el COALESCE per a obtindre els not null primer
carlosap added 1 commit 2024-11-19 15:58:20 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
43abb52efc refactor: refs #8210 ticket_splitItemPackingType
carlosap requested review from pako 2024-11-19 16:00:43 +00:00
pako requested changes 2024-11-20 06:35:06 +00:00
Dismissed
pako left a comment
Member
Copy Link

Quan pugues vine i et mostre el resultat en les fixtures

Quan pugues vine i et mostre el resultat en les fixtures
carlosap added 1 commit 2024-11-20 18:19:08 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
031c4398ae refactor: refs #8210 ticket_splitItemPackingType
carlosap requested review from pako 2024-11-20 18:24:47 +00:00
carlosap added 1 commit 2024-11-21 11:54:03 +00:00
pako approved these changes 2024-11-21 12:21:55 +00:00
carlosap merged commit dbf71b981e into dev 2024-11-21 12:39:35 +00:00
carlosap deleted branch 8210-RefactorTicket_splitItemPackingType 2024-11-21 12:39:35 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
pako
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#3217
No description provided.
Delete Branch "8210-RefactorTicket_splitItemPackingType"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?