verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 62 Releases Wiki Activity

#7936 fineTunningInvoiceIn #3251

Merged
jorgep merged 39 commits from 7936-fineTunningInvoiceIn into dev 2024-12-18 09:22:02 +00:00
Conversation 0 Commits 39 Files Changed 24 +409 -39
jorgep commented 2024-11-26 15:57:00 +00:00
Member
Copy Link
No description provided.
jorgep added 4 commits 2024-11-26 15:57:00 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
ca3ac64072 feat: refs #4460 invoiceIn refund
gitea/salix/pipeline/pr-dev This commit looks good Details
2a1fa8ca68 feat: refs #4466 invoiceIn refund
jorgep added 1 commit 2024-11-26 16:02:01 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
a68e287b23 refactor: refs #7936 remove old trigger and add isRaid column to travel table
jorgep added 1 commit 2024-11-26 16:06:56 +00:00
jorgep added 1 commit 2024-11-27 08:41:29 +00:00
jorgep added 1 commit 2024-11-27 09:24:18 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
5db1262e08 feat: refs #7936 add company filter
jorgep added 1 commit 2024-11-27 12:12:40 +00:00
jorgep added 1 commit 2024-11-27 16:52:49 +00:00
jorgep added 1 commit 2024-11-28 10:06:02 +00:00
jorgep added 1 commit 2024-11-28 13:52:47 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
7d5ae9dfbd feat: refs #7936 add reference rates for currency in fixtures
jorgep added 1 commit 2024-11-29 08:41:14 +00:00
jorgep added 1 commit 2024-11-29 10:53:11 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
1f6e401e39 feat: refs #7936 add save validation
jorgep added 1 commit 2024-11-29 11:22:06 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
332e1c62d9 feat: refs #7936 add validation to InvoiceIn & InvoiceInTax
jorgep added 2 commits 2024-11-29 11:42:18 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
9ece52c5ce feat: refs #7936 add currency check to updateInvoiceIn
jorgep added 1 commit 2024-11-29 12:44:49 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
163c6ddd20 feat: refs #7936 add currency handling in invoiceIn trigger
jorgep added 1 commit 2024-11-29 13:32:18 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
c9cf96676b fix: refs #7936 check if insert in hook & change test description
jorgep changed title from 7936-fineTunningInvoiceIn to #7936 fineTunningInvoiceIn 2024-11-29 13:33:17 +00:00
jorgep added 1 commit 2024-11-29 14:49:18 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
ac87905351 feat: refs #7936 add back test for updateInvoiceIn
jorgep added 1 commit 2024-11-29 15:25:52 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
59b5dd5a36 feat: refs #7936 add tests for invoiceIn
jorgep added 1 commit 2024-11-29 16:05:17 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
00085f2b99 feat: refs #7936 add tests for invoiceIn filter
jorgep added 1 commit 2024-12-02 16:11:28 +00:00
jorgep added 1 commit 2024-12-02 16:48:44 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
5b04debfb1 refactor: refs #7936 add transaction & tests
jorgep added 1 commit 2024-12-04 12:32:01 +00:00
jorgep added 1 commit 2024-12-05 09:10:46 +00:00
jorgep added the
CR / Tests passed
 label 2024-12-05 14:20:15 +00:00
jorgep requested review from carlosap 2024-12-05 14:20:24 +00:00
jorgep requested review from jgallego 2024-12-05 14:20:41 +00:00
jgallego requested changes 2024-12-09 09:42:06 +00:00
Dismissed
db/routines/vn/triggers/invoiceIn_afterUpdate.sql Outdated
@ -7,1 +6,3 @@
OR NEW.currencyFk != OLD.currencyFk THEN
DECLARE vIsEuro BOOL;
SELECT if(`code` = 'EUR', TRUE, FALSE) INTO vIsEuro
jgallego commented 2024-12-09 09:28:41 +00:00
Owner
Copy Link

SELECT (code = 'EUR') vIsEuro
dejalo así que es lo mismo pero es mas compacto

SELECT (`code` = 'EUR') vIsEuro dejalo así que es lo mismo pero es mas compacto
jorgep marked this conversation as resolved
db/versions/11368-whiteAspidistra/00-firstScript.sql
@ -0,0 +13,4 @@
WHERE id = 3;
DELIMITER $$
CREATE OR REPLACE DEFINER=`vn`@`localhost` TRIGGER `vn`.`invoiceIn_beforeUpdate`
jgallego commented 2024-12-09 09:33:21 +00:00
Owner
Copy Link

porque no lo has puesto en el propio archivo invoiceIn_beforeUpdate

porque no lo has puesto en el propio archivo invoiceIn_beforeUpdate
jorgep commented 2024-12-09 12:57:11 +00:00
Author
Member
Copy Link

Es necesario para poder hacer los updates de arriba, si no no se puede(el contenido del trigger no cambia). Hablado con Carlos Andrés.

Es necesario para poder hacer los updates de arriba, si no no se puede(el contenido del trigger no cambia). Hablado con Carlos Andrés.
db/versions/11368-whiteAspidistra/00-firstScript.sql Outdated
@ -0,0 +37,4 @@
IF NEW.supplierFk != OLD.supplierFk THEN
CALL supplier_checkIsActive(NEW.supplierFk);
SELECT withholdingSageFk INTO vWithholdingSageFk
FROM vn.supplier
jgallego commented 2024-12-09 09:32:55 +00:00
Owner
Copy Link

no se pone vn. es innecesario

no se pone vn. es innecesario
carlosap marked this conversation as resolved
carlosap approved these changes 2024-12-09 10:43:31 +00:00
Dismissed
jorgep added 1 commit 2024-12-09 12:50:17 +00:00
jorgep added 1 commit 2024-12-09 13:03:51 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
f69dfbd5aa refactor: refs #7936 remove schema
jorgep requested review from jgallego 2024-12-09 13:05:04 +00:00
jorgep added 1 commit 2024-12-09 15:59:04 +00:00
jgallego approved these changes 2024-12-09 16:42:33 +00:00
jorgep added 1 commit 2024-12-10 09:27:39 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
46448d5fc2 fix: refs #7936 change type
jorgep added 1 commit 2024-12-11 08:29:12 +00:00
jorgep added 1 commit 2024-12-11 16:25:51 +00:00
jorgep added 1 commit 2024-12-11 16:42:08 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
addb093b6b feat: refs #7936 add minimum due date
jorgep added 1 commit 2024-12-12 08:58:49 +00:00
jorgep added 1 commit 2024-12-12 10:20:28 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
c83f34859a feat: refs #7936 return country code & is vies fields
jorgep added 2 commits 2024-12-16 08:35:44 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
d9eab36160 fix: refs #7936 conflicts
carlosap approved these changes 2024-12-16 10:28:54 +00:00
jorgep added 1 commit 2024-12-17 09:52:00 +00:00
jorgep added 1 commit 2024-12-18 09:18:52 +00:00
jorgep merged commit dd5d9bcb08 into dev 2024-12-18 09:22:02 +00:00
jorgep deleted branch 7936-fineTunningInvoiceIn 2024-12-18 09:22:03 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
carlosap
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#3251
No description provided.
Delete Branch "7936-fineTunningInvoiceIn"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?