verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 53 Releases Wiki Activity

#7936 fineTunningInvoiceIn #3251

Merged
jorgep merged 39 commits from 7936-fineTunningInvoiceIn into dev 2024-12-18 09:22:02 +00:00
Conversation 0 Commits 39 Files Changed 24 +6 -6
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit f69dfbd5aa - Show all commits

2
db/routines/vn/triggers/invoiceIn_afterUpdate.sql
View File

@ -5,7 +5,7 @@ CREATE OR REPLACE DEFINER=`vn`@`localhost` TRIGGER `vn`.`invoiceIn_afterUpdate`
BEGIN BEGIN
DECLARE vIsEuro BOOL; DECLARE vIsEuro BOOL;
SELECT if(`code` = 'EUR', TRUE, FALSE) INTO vIsEuro SELECT `code` = 'EUR' INTO vIsEuro
jorgep marked this conversation as resolved Outdated
jgallego commented 2024-12-09 09:28:41 +00:00
Outdated
Review
Copy Link

SELECT (code = 'EUR') vIsEuro
dejalo así que es lo mismo pero es mas compacto

SELECT (`code` = 'EUR') vIsEuro dejalo así que es lo mismo pero es mas compacto
FROM currency FROM currency
WHERE id = NEW.currencyFk; WHERE id = NEW.currencyFk;

10
db/versions/11368-whiteAspidistra/00-firstScript.sql
View File

@ -2,13 +2,13 @@
DROP TRIGGER IF EXISTS invoiceIn_beforeUpdate; DROP TRIGGER IF EXISTS invoiceIn_beforeUpdate;
UPDATE vn.invoiceIn UPDATE invoiceIn
SET cplusRectificationTypeFk = NULL SET cplusRectificationTypeFk = NULL
WHERE cplusRectificationTypeFk = 1; WHERE cplusRectificationTypeFk = 1;
DELETE IGNORE FROM vn.cplusRectificationType WHERE id = 1; DELETE IGNORE FROM cplusRectificationType WHERE id = 1;
UPDATE vn.cplusRectificationType UPDATE cplusRectificationType
SET id = 1 SET id = 1
WHERE id = 3; WHERE id = 3;
@ -25,7 +25,7 @@ BEGIN
SET NEW.editorFk = account.myUser_getId(); SET NEW.editorFk = account.myUser_getId();
IF (SELECT COUNT(*) FROM vn.invoiceIn IF (SELECT COUNT(*) FROM invoiceIn
WHERE supplierRef = NEW.supplierRef WHERE supplierRef = NEW.supplierRef
AND supplierFk = NEW.supplierFk AND supplierFk = NEW.supplierFk
AND YEAR(issued) = YEAR(NEW.issued) AND YEAR(issued) = YEAR(NEW.issued)
@ -37,7 +37,7 @@ BEGIN
IF NEW.supplierFk != OLD.supplierFk THEN IF NEW.supplierFk != OLD.supplierFk THEN
CALL supplier_checkIsActive(NEW.supplierFk); CALL supplier_checkIsActive(NEW.supplierFk);
SELECT withholdingSageFk INTO vWithholdingSageFk SELECT withholdingSageFk INTO vWithholdingSageFk
FROM vn.supplier FROM supplier
carlosap marked this conversation as resolved Outdated
jgallego commented 2024-12-09 09:32:55 +00:00
Outdated
Review
Copy Link

no se pone vn. es innecesario

no se pone vn. es innecesario
WHERE id = NEW.supplierFk; WHERE id = NEW.supplierFk;
SET NEW.withholdingSageFk = vWithholdingSageFk; SET NEW.withholdingSageFk = vWithholdingSageFk;
END IF; END IF;