feat: refs #7882 Added osrmservice #3281

Merged
guillermo merged 16 commits from 7882-locationiq into dev 2024-12-16 06:58:54 +00:00
Member
No description provided.
guillermo added 1 commit 2024-12-08 13:30:11 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
8960b54664
feat: refs #7882 Added locationiq service
guillermo added 1 commit 2024-12-09 08:12:01 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
0bb9282953
feat: refs #7882 Added locationiq service
guillermo added 1 commit 2024-12-09 09:02:03 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
e279cc4b47
feat: refs #7882 Added osrm service
guillermo added 1 commit 2024-12-09 09:21:28 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
85baf151d9
feat: refs #7882 Fixed problems osrm service
guillermo added 1 commit 2024-12-09 13:45:35 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
cba5d88c5e
feat: refs #7882 Osrm service
guillermo added 1 commit 2024-12-11 08:03:19 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
c8ec94bed9
feat: refs #7882 Osrm service
guillermo changed title from feat: refs #7882 Added locationiq service to feat: refs #7882 Added osrmservice 2024-12-11 08:56:52 +00:00
guillermo added 1 commit 2024-12-11 10:41:45 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
252a029c98
feat: refs #7882 Osrm service
guillermo added 1 commit 2024-12-11 10:44:27 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
bc072208d7
Merge branch 'dev' into 7882-osrm
guillermo requested review from jgallego 2024-12-11 10:44:33 +00:00
guillermo requested review from alexm 2024-12-11 10:44:48 +00:00
guillermo added 1 commit 2024-12-11 13:55:30 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
186ef52518
feat: refs #7882 Osrm service
jgallego requested changes 2024-12-11 15:33:35 +00:00
Dismissed
@ -0,0 +54,4 @@
}
if (lastAddressId) {
const firstAddress = await models.Address.findById(lastAddressId);
Owner

donali un altre nom, ixe l'has gastat dalt i pots ser confús.

donali un altre nom, ixe l'has gastat dalt i pots ser confús.
guillermo marked this conversation as resolved
@ -0,0 +72,4 @@
const response = await axios.post(`
${osrmConfig.url}/trip/v1/driving/${concatCoords}?source=first&destination=last&roundtrip=true
`);
const tolerance = osrmConfig.tolerance;
Owner

en tots els for declaren la variable
for (let waypoint of response.data.waypoints) {

en tots els for declaren la variable ` for (let waypoint of response.data.waypoints) { `
guillermo marked this conversation as resolved
@ -0,0 +73,4 @@
${osrmConfig.url}/trip/v1/driving/${concatCoords}?source=first&destination=last&roundtrip=true
`);
const tolerance = osrmConfig.tolerance;
for (waypoint of response.data.waypoints) {
Owner

conve posar açò?

if (!response.data || !response.data.waypoints) {
    throw new UserError('Invalid response from OSRM');
}
conve posar açò? ``` if (!response.data || !response.data.waypoints) { throw new UserError('Invalid response from OSRM'); } ```
Author
Member

No perque dins ja se maneja

No perque dins ja se maneja
guillermo marked this conversation as resolved
@ -0,0 +28,4 @@
if (typeof options == 'object')
Object.assign(myOptions, options);
const ticketsIds = await models.Ticket.find({
Owner

const tickets

const tickets
guillermo marked this conversation as resolved
@ -0,0 +106,4 @@
// Realizamos el update en la base de datos
try {
await Promise.all(ticketAddress.map(async y => {
Owner

y que tinga un nom descriptiu

y que tinga un nom descriptiu
Author
Member

Ací no entenc que vols dir

Ací no entenc que vols dir
guillermo marked this conversation as resolved
guillermo added 1 commit 2024-12-12 07:23:07 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
65e195d77d
feat: refs #7882 Requested changes
guillermo requested review from jgallego 2024-12-12 07:56:36 +00:00
Author
Member

Javi me ha dicho presencialmente que haga también los tests

Javi me ha dicho presencialmente que haga también los tests
guillermo added 1 commit 2024-12-12 13:06:47 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
95d7c7f227
Merge branch 'dev' into 7882-osrm
guillermo added 1 commit 2024-12-12 13:36:02 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
05ba85219b
feat: refs #7882 Osrm service
jgallego approved these changes 2024-12-12 16:14:00 +00:00
Dismissed
jgallego left a comment
Owner

Faltarien sols els test

Faltarien sols els test
guillermo added 1 commit 2024-12-13 06:30:46 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
bfad016ec4
Merge branch 'dev' into 7882-osrm
guillermo added 1 commit 2024-12-13 07:07:17 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
00b5333ab7
feat: refs #7882 Added tests
alexm requested changes 2024-12-16 06:10:43 +00:00
Dismissed
@ -0,0 +13,4 @@
arg: 'firstAddressId',
type: 'number',
required: false
}],
Member

Falta el parametre lastAddressId

Falta el parametre lastAddressId
guillermo marked this conversation as resolved
guillermo requested review from jgallego 2024-12-16 06:15:51 +00:00
guillermo added 1 commit 2024-12-16 06:15:53 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
233f45a07a
feat: refs #7882 Reequested changes
guillermo requested review from alexm 2024-12-16 06:15:53 +00:00
guillermo added 1 commit 2024-12-16 06:16:06 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
e1db7a86f6
Merge branch 'dev' into 7882-locationiq
alexm approved these changes 2024-12-16 06:19:18 +00:00
jgallego approved these changes 2024-12-16 06:32:14 +00:00
guillermo merged commit eadffe1ed9 into dev 2024-12-16 06:58:54 +00:00
guillermo deleted branch 7882-locationiq 2024-12-16 06:58:54 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#3281
No description provided.