verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 63 Releases Wiki Activity

#7832 - ticketServiceModifyConcept #3332

Merged
jgallego merged 3 commits from 7832-ticketServiceModifyConcept into dev 2025-01-07 07:45:42 +00:00
Conversation 1 Commits 3 Files Changed 2 +74 -1
jgallego commented 2024-12-31 10:48:59 +00:00
Owner
Copy Link
No description provided.
jgallego added 2 commits 2024-12-31 10:49:00 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
0ad26b336d fix: refs #7832 update ticketService model test suite to correct describe block
jgallego requested review from jsegarra 2024-12-31 10:50:10 +00:00
jsegarra requested changes 2024-12-31 11:26:24 +00:00
Dismissed
modules/ticket/back/models/specs/ticket-service.spec.js
@ -0,0 +55,4 @@
quantity: 5
}, opts);
fail('Should have thrown error');
jsegarra commented 2024-12-31 11:26:20 +00:00
Member
Copy Link

El texto del fail no me cueadra con la descripcion del caso.
Es correcto que queremos un fail para "dejar actualizar(allow updating)"??

El texto del fail no me cueadra con la descripcion del caso. Es correcto que queremos un fail para "dejar actualizar(allow updating)"??
jsegarra commented 2024-12-31 11:28:04 +00:00
Member
Copy Link

He quitado esta linea y me siguen pasando

He quitado esta linea y me siguen pasando
jgallego commented 2025-01-01 09:07:55 +00:00
Author
Owner
Copy Link

la cuestion es que esa linea nunca deberia ejecutarse, para que el test vaya bien, el try deberia dar fallo y pasar al catch, esa linea es un salvavidas por si alguien hace que el updatAttributes no falle, se ejecuta el fail.

la cuestion es que esa linea nunca deberia ejecutarse, para que el test vaya bien, el try deberia dar fallo y pasar al catch, esa linea es un salvavidas por si alguien hace que el updatAttributes no falle, se ejecuta el fail.
jsegarra commented 2025-01-03 15:34:04 +00:00
Member
Copy Link

Si, lo sé, lo hemos comentado alguna vez
Te he puesto una captura diciéndote que con o sin esa linea, el test pasa igualmente.
Entiendo que lo haces de cara a futuro.

Si, lo sé, lo hemos comentado alguna vez Te he puesto una captura diciéndote que con o sin esa linea, el test pasa igualmente. Entiendo que lo haces de cara a futuro.
jsegarra commented 2024-12-31 11:28:20 +00:00
Member
Copy Link

Quitando la linea fail me pasa igualmente
image

Quitando la linea fail me pasa igualmente ![image](/attachments/1fa6bfe6-22a7-4242-84f5-002a44e91b8d)
image.png
54 KiB
jsegarra changed title from 7832-ticketServiceModifyConcept to #7832 - ticketServiceModifyConcept 2024-12-31 11:28:29 +00:00
jgallego requested review from jsegarra 2025-01-01 09:08:03 +00:00
jsegarra approved these changes 2025-01-03 15:34:06 +00:00
jgallego added 1 commit 2025-01-07 07:43:22 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
4f3c101e42 Merge branch 'dev' into 7832-ticketServiceModifyConcept
jgallego merged commit 399081f83c into dev 2025-01-07 07:45:42 +00:00
jgallego deleted branch 7832-ticketServiceModifyConcept 2025-01-07 07:45:42 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jsegarra
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#3332
No description provided.
Delete Branch "7832-ticketServiceModifyConcept"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?