feat: refs #7343 delete sending to user #3334

ivanm · 2025-01-02T17:05:54Z

ivanm commented

2025-01-02 17:05:54 +00:00

No description provided.

ivanm added 1 commit 2025-01-02 17:05:55 +00:00

gitea/salix/pipeline/pr-dev This commit looks good Details

8822fde7fb feat: refs #7343 delete sending to user

ivanm requested review from guillermo 2025-01-03 08:09:59 +00:00

guillermo requested changes 2025-01-07 06:30:22 +00:00

Dismissed

guillermo left a comment

Si ho has provat en local i funciona ok avant

modules/route/back/methods/route/driverRouteEmail.js

						
				@ -34,3 +34,1 @@

				        const models = Self.app.models;

				        const {workerFk, agencyMode} = await Self.findById(id, {

				            fields: ['workerFk', 'agencyModeFk'],

				        const {agencyMode} = await Self.findById(id, {

guillermo commented

2025-01-07 06:29:39 +00:00

De la linea 34 a la 40 crec que pots unificar-ho

ivanm commented

2025-01-07 16:47:08 +00:00

He intentat unificar-ho de varies formes, he intentat fer un scope de reportMail per a que només carregue eixa columna, però no he trobat la forma. He anat a la api varies vegades i sempre m'ha donat error. Amb el codi com el tens la api respon correctament. Si tens alguna idea per a unificar més eixes linies m'ho dius i faig la prova.

guillermo commented

2025-01-08 06:48:08 +00:00

Has probado esto?

const route = await Self.findById(id, {
    fields: ['agencyModeFk'],
    include: {relation: 'agencyMode'}
});

ctx.args.recipient = route?.agencyMode?.reportMail;

Has probado esto? ``` const route = await Self.findById(id, { fields: ['agencyModeFk'], include: {relation: 'agencyMode'} }); ctx.args.recipient = route?.agencyMode?.reportMail; ```

ivanm commented

2025-01-08 12:03:10 +00:00

Dona error 400 amb el codi que m'has passat:

{
  "error": {
    "statusCode": 400,
    "name": "UserError",
    "message": "Es necesario un email",
    "translateArgs": [],
    "stack": "UserError: Es necesario un email\n    at Self.driverRouteEmail (/home/ivanm/Projects/salix/modules/route/back/methods/route/driverRouteEmail.js:40:40)"
  }
}

Dona error 400 amb el codi que m'has passat: ``` { "error": { "statusCode": 400, "name": "UserError", "message": "Es necesario un email", "translateArgs": [], "stack": "UserError: Es necesario un email\n at Self.driverRouteEmail (/home/ivanm/Projects/salix/modules/route/back/methods/route/driverRouteEmail.js:40:40)" } } ```

guillermo commented

2025-01-08 12:09:02 +00:00

Pero te has asegurat de que realment tinga email en la db?

ivanm marked this conversation as resolved

ivanm requested review from guillermo 2025-01-07 16:47:30 +00:00

ivanm added 1 commit 2025-01-07 16:47:46 +00:00