verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

2162-print_pdf_puppeteer #335

Merged
joan merged 6 commits from 2162-print_pdf_puppeteer into dev 2020-07-09 07:26:51 +00:00
Conversation 0 Commits 6 Files Changed 21 +147 -183
joan commented 2020-07-06 09:21:00 +00:00
Contributor
Copy Link
No description provided.
joan changed title from 2162-print_pdf_puppeteer to WIP: 2162-print_pdf_puppeteer 2020-07-06 09:33:03 +00:00
joan changed title from WIP: 2162-print_pdf_puppeteer to 2162-print_pdf_puppeteer 2020-07-06 11:11:30 +00:00
joan requested review from bernat 2020-07-09 06:30:14 +00:00
bernat approved these changes 2020-07-09 06:46:03 +00:00
bernat left a comment
Contributor
Copy Link

lgtm

lgtm
print/core/report.js
@ -1,5 +1,6 @@
const fs = require('fs');
const pdf = require('html-pdf');
// const pdf = require('html-pdf');
bernat commented 2020-07-09 06:45:03 +00:00
Contributor
Copy Link

delete commnet

delete commnet
joan merged commit bdc37e7fc1 into dev 2020-07-09 07:26:51 +00:00
joan deleted branch 2162-print_pdf_puppeteer 2020-07-14 11:51:36 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
bernat
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#335
No description provided.
Delete Branch "2162-print_pdf_puppeteer"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?