verdnatura/salix
verdnatura
/
salix
3
5
Fork 0
Code Issues Pull Requests 66 Releases Wiki Activity

feat: refs #8387 crudModel #3355

Merged
robert merged 16 commits from 8387-itemTagCrudModel into dev 2025-01-27 11:38:09 +00:00
Conversation 0 Commits 16 Files Changed 4 +29 -1
robert commented 2025-01-13 13:29:25 +00:00
Member
Copy Link
No description provided.
robert added 1 commit 2025-01-13 13:29:25 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
050c338ffb feat: refs #8387 crudModel
robert added 1 commit 2025-01-13 13:33:37 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
6fd8c5ded6 feat: refs #8387 fix
robert added 1 commit 2025-01-13 13:39:14 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
da3b8ac8d0 Merge branch 'dev' into 8387-itemTagCrudModel
robert added 1 commit 2025-01-15 09:25:26 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
93c9ef6f4c feat: refs #8387 changes
robert added 1 commit 2025-01-21 10:25:08 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
c727586855 feat: refs #8387 add column validationRegex
robert added 1 commit 2025-01-21 12:12:07 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
3d5bfb81da feat: refs #8387 regular expression all tags
robert added 1 commit 2025-01-21 12:13:34 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
b4ac80615b feat: refs #8387 fix traductions
robert added 1 commit 2025-01-21 12:40:29 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
a40e9a547b feat: refs #8387
robert added 1 commit 2025-01-21 12:42:18 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
5ff27de72c feat: refs #8387
robert added 1 commit 2025-01-21 13:13:34 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
3c89ea0df8 fix: refs #8387 local/es.json
robert added 1 commit 2025-01-21 13:14:37 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
2e247c3ea5 Merge branch 'dev' into 8387-itemTagCrudModel
robert added 1 commit 2025-01-27 06:17:51 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
b9206c44bb Merge branch 'dev' into 8387-itemTagCrudModel
robert added 1 commit 2025-01-27 07:10:57 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
46a22733e2 Merge branch 'dev' into 8387-itemTagCrudModel
robert requested review from alexm 2025-01-27 07:17:34 +00:00
alexm requested changes 2025-01-27 07:28:48 +00:00
Dismissed
modules/item/back/models/item-tag.js Outdated
@ -13,0 +23,4 @@
value = ctx.data.value;
}
const models = Self.app.models;
const validTag = await models.Tag.findOne({where: {id: tagFk}});
alexm commented 2025-01-27 07:28:05 +00:00
Member
Copy Link

findById

findById
robert marked this conversation as resolved
modules/item/back/models/item-tag.js
@ -13,0 +25,4 @@
const models = Self.app.models;
const validTag = await models.Tag.findOne({where: {id: tagFk}});
if (validTag.validationRegex) {
alexm commented 2025-01-27 07:28:46 +00:00
Member
Copy Link

&& de value deberia ir a este nivel no?

&& de value deberia ir a este nivel no?
robert commented 2025-01-27 08:05:20 +00:00
Author
Member
Copy Link

validTag.validationRegex comprueba si la columna validationRegex de la tabla tag tiene una expresión regular, y en caso de tener, se comprueba si el valor cumple la expresión regular

validTag.validationRegex comprueba si la columna validationRegex de la tabla tag tiene una expresión regular, y en caso de tener, se comprueba si el valor cumple la expresión regular
robert marked this conversation as resolved
robert added 1 commit 2025-01-27 07:59:41 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
1f6779d86b feat: refs #8387 change request
robert added 1 commit 2025-01-27 08:05:29 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
d10670cb37 Merge branch 'dev' into 8387-itemTagCrudModel
robert requested review from alexm 2025-01-27 08:05:43 +00:00
alexm approved these changes 2025-01-27 09:06:41 +00:00
robert added 1 commit 2025-01-27 10:26:52 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
5a449c66ce Merge branch 'dev' into 8387-itemTagCrudModel
robert merged commit 56982ee1ba into dev 2025-01-27 11:38:09 +00:00
robert deleted branch 8387-itemTagCrudModel 2025-01-27 11:38:09 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexm
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#3355
No description provided.
Delete Branch "8387-itemTagCrudModel"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?