verdnatura/salix
verdnatura
/
salix
3
5
Fork 2
Code Issues Pull Requests 73 Releases Wiki Activity

feat(available): refs #8408 available refreshing now includes time #3395

Merged
pako merged 5 commits from 8408-Disponible-por-zonas-y-horas into dev 2025-01-29 12:57:14 +00:00
Conversation 0 Commits 5 Files Changed 6 +22 -12
pako commented 2025-01-29 11:04:21 +00:00
Member
Copy Link

Refs: #8408

Refs: #8408
pako added 1 commit 2025-01-29 11:04:22 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
0de9c3c172 feat(available): refs #8408 available refreshing now includes time 
Refs: #8408
pako added 1 commit 2025-01-29 11:12:26 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
4e2a6d275a fix(travel): refs #8408 trigger restriction for wrong availabled value 
Refs: #8408
pako added 1 commit 2025-01-29 11:15:08 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
597615facb fix(agencyIncomingForeign): refs #8408 version changes rolled back 
Refs: #8408
pako requested review from jgallego 2025-01-29 11:16:32 +00:00
pako added 1 commit 2025-01-29 11:16:43 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
af5b4981df Merge branch 'dev' into 8408-Disponible-por-zonas-y-horas
jgallego requested changes 2025-01-29 11:27:41 +00:00
Dismissed
db/versions/11424-navyRose/00-travel.sql
@ -0,0 +1,3 @@
-- Place your SQL code here
ALTER TABLE vn.travel ADD IF NOT EXISTS availabled DATETIME NULL
jgallego commented 2025-01-29 11:27:40 +00:00
Owner
Copy Link

es molt especific availabled, perque tambe se podria dir visibled, perque a la vegada també estará visible.
Proposta: La taula travel te el camp landingHour, que jo gastaria ixe perque esta en desus per açò, canviant el tipo a datetime.

es molt especific availabled, perque tambe se podria dir visibled, perque a la vegada també estará visible. Proposta: La taula travel te el camp landingHour, que jo gastaria ixe perque esta en desus per açò, canviant el tipo a datetime.
pako commented 2025-01-29 12:17:32 +00:00
Author
Member
Copy Link

jo deixaria el landingHour per si es volguera fer servir per a organitzar les arrivades reals. El nou camp no pot ser visibled perque no fa referència al moment en el que arriven les coses, sino al moment en el que volem que apareguen a la venta. Per eixample, arriven coses que es tarda varios dies en etiquetar, i en eixe cas el availabled té tot el sentit. El nom del camp es auto-definidor, com sempre anem intentant....

jo deixaria el landingHour per si es volguera fer servir per a organitzar les arrivades reals. El nou camp no pot ser visibled perque no fa referència al moment en el que arriven les coses, sino al moment en el que volem que apareguen a la venta. Per eixample, arriven coses que es tarda varios dies en etiquetar, i en eixe cas el availabled té tot el sentit. El nom del camp es auto-definidor, com sempre anem intentant....
pako marked this conversation as resolved
jgallego approved these changes 2025-01-29 12:19:29 +00:00
pako added 1 commit 2025-01-29 12:54:10 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
73d1266bfc Merge branch 'dev' into 8408-Disponible-por-zonas-y-horas
pako merged commit e87803874c into dev 2025-01-29 12:57:14 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#3395
No description provided.
Delete Branch "8408-Disponible-por-zonas-y-horas"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?