verdnatura/salix
verdnatura
/
salix
3
5
Fork 0
Code Issues Pull Requests 49 Releases Wiki Activity

6702-missageSaleCloned #3404

Merged
robert merged 15 commits from 6702-missageSaleCloned into dev 2025-02-07 06:51:07 +00:00
Conversation 0 Commits 15 Files Changed 5 +35 -12
robert commented 2025-01-31 06:03:51 +00:00
Member
Copy Link
No description provided.
robert added 4 commits 2025-01-31 06:03:51 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
eca2ff84ef feat: refs #6702 changes
robert added 1 commit 2025-01-31 06:09:47 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
1e18e48f8c feat: refs #6702 es.json delete changes
robert added 1 commit 2025-01-31 06:14:16 +00:00
robert added 1 commit 2025-01-31 07:19:45 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
948bdbd2c6 feat: refs #6702 refs #6701 changes
robert added 2 commits 2025-01-31 11:53:55 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
9d3a4257b7 feat: refs #6702 translations
robert added 1 commit 2025-01-31 12:17:11 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
1a8ce32833 Merge branch 'dev' into 6702-missageSaleCloned
robert added 1 commit 2025-02-03 06:11:50 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
d98476b777 Merge branch 'dev' into 6702-missageSaleCloned
robert requested review from jgallego 2025-02-03 06:12:29 +00:00
jgallego requested changes 2025-02-03 07:11:46 +00:00
Dismissed
modules/ticket/back/models/sale.js Outdated
@ -139,0 +140,4 @@
Self.ticketWeekly = async function(saleId) {
const SaleCloned = Self.app.models.SaleCloned;
const saleCloned2 = await SaleCloned.findOne({
jgallego commented 2025-02-03 07:11:39 +00:00
Owner
Copy Link

realment sols has de cridar ací, no cal crear una funció aposta, ja que no la crides mes vegades.

const saleCloned2 = await SaleCloned.findById(saleId, {
include: 'saleOriginal'
});

posa este codi en la funcio principal, i fes un test que verifique la nova logica en back

realment sols has de cridar ací, no cal crear una funció aposta, ja que no la crides mes vegades. const saleCloned2 = await SaleCloned.findById(saleId, { include: 'saleOriginal' }); posa este codi en la funcio principal, i fes un test que verifique la nova logica en back
robert marked this conversation as resolved
robert added 1 commit 2025-02-03 11:41:55 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
0646d2e817 feat: refs #6702 changes request
robert added 1 commit 2025-02-03 11:42:43 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
d79c19d92a feat: refs #6702 delete line
robert added 1 commit 2025-02-03 12:37:15 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
14a48bf4c6 Merge branch 'dev' into 6702-missageSaleCloned
robert requested review from jgallego 2025-02-03 13:01:25 +00:00
jgallego approved these changes 2025-02-04 13:40:13 +00:00
robert added 1 commit 2025-02-06 13:31:41 +00:00
robert merged commit 860d86d19e into dev 2025-02-07 06:51:07 +00:00
robert deleted branch 6702-missageSaleCloned 2025-02-07 06:51:07 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#3404
No description provided.
Delete Branch "6702-missageSaleCloned"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?