verdnatura/salix
verdnatura
/
salix
3
5
Fork 0
Code Issues Pull Requests 63 Releases Wiki Activity

refactor: refs #8573 add fk to expedition.hostFk #3447

Merged
ivanm merged 5 commits from 8573-addFkExpeditionHost into dev 2025-02-14 07:06:22 +00:00
Conversation 1 Commits 5 Files Changed 4 +20 -2
ivanm commented 2025-02-12 16:09:55 +00:00
Member
Copy Link
No description provided.
ivanm added 1 commit 2025-02-12 16:09:55 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
5404f895b2 refactor: refs #8573 add fk to expedition.hostFk
ivanm added 1 commit 2025-02-12 16:11:54 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
f12c47cdf8 Merge branch 'dev' into 8573-addFkExpeditionHost
ivanm requested review from guillermo 2025-02-12 18:57:21 +00:00
guillermo requested changes 2025-02-13 06:01:52 +00:00
Dismissed
guillermo left a comment
Member
Copy Link

Antes de insertar la FK, asegurat be, ja que si hi ha un registre que no está en host, et donará error.

Els que no estiguen ficarlos a NULL

Antes de insertar la FK, asegurat be, ja que si hi ha un registre que no está en host, et donará error. Els que no estiguen ficarlos a NULL
guillermo reviewed 2025-02-13 06:03:08 +00:00
modules/ticket/back/methods/boxing/getVideo.js Outdated
@ -49,7 +49,7 @@ module.exports = Self => {
ps.monitorId,
e.created
FROM expedition e
JOIN host h ON Convert(h.code USING utf8mb3) COLLATE utf8mb3_unicode_ci = e.hostFk
guillermo commented 2025-02-13 06:03:08 +00:00
Member
Copy Link

Aço aixina ara donaria error? En cas afirmatiu, en ENC i en més puestos donará error.

Aço aixina ara donaria error? En cas afirmatiu, en ENC i en més puestos donará error.
ivanm commented 2025-02-13 12:11:00 +00:00
Author
Member
Copy Link

Sí, dona error, per això ho he canviat. En el redmine tens les dependències però, bàsicament, he trobat una en encajado:
Encajado:
Query: qryRePrintMrw
Type: Pass through
que canviaré en el moment en que puje el PR a dev i 3 grafanes que canviaré amb la pujada a producció
També hi ha una en vn-rfid (per això te vaig preguntar ahir) que també vaig a fer-te un PR a dev

Sí, dona error, per això ho he canviat. En el redmine tens les dependències però, bàsicament, he trobat una en encajado: Encajado: Query: qryRePrintMrw Type: Pass through que canviaré en el moment en que puje el PR a dev i 3 grafanes que canviaré amb la pujada a producció També hi ha una en vn-rfid (per això te vaig preguntar ahir) que també vaig a fer-te un PR a dev
ivanm marked this conversation as resolved
guillermo commented 2025-02-13 13:53:44 +00:00
Member
Copy Link

Queda pendiente hacer lo que hemos hablado, para que cuando se suba no falle en ningún caso, aunque inserten un registro que no exista.

Queda pendiente hacer lo que hemos hablado, para que cuando se suba no falle en ningún caso, aunque inserten un registro que no exista.
ivanm added 1 commit 2025-02-13 15:41:41 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
caa921020d refactor: refs #8573 update before alter table
ivanm added 1 commit 2025-02-13 15:43:59 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
13a76e5c70 Merge branch 'dev' into 8573-addFkExpeditionHost
ivanm requested review from guillermo 2025-02-13 15:45:46 +00:00
guillermo reviewed 2025-02-14 06:26:29 +00:00
db/versions/11441-limeCyca/01-firstScript.sql
@ -0,0 +1,9 @@
ALTER TABLE vn.expedition
MODIFY COLUMN hostFk VARCHAR(30) COLLATE utf8mb3_general_ci;
guillermo commented 2025-02-14 06:26:29 +00:00
Member
Copy Link

Estos alters poden anar junts

Estos alters poden anar junts
guillermo approved these changes 2025-02-14 06:26:44 +00:00
ivanm added 1 commit 2025-02-14 06:55:50 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
5a37bd332e Merge branch 'dev' into 8573-addFkExpeditionHost
ivanm merged commit 9000becf07 into dev 2025-02-14 07:06:22 +00:00
ivanm deleted branch 8573-addFkExpeditionHost 2025-02-14 07:06:22 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
guillermo
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#3447
No description provided.
Delete Branch "8573-addFkExpeditionHost"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?