verdnatura/salix
verdnatura
/
salix
3
5
Fork 2
Code Issues Pull Requests 70 Releases Wiki Activity

refactor: refs #8613 add fk to claimEnd.claimDestinationFk #3479

Merged
ivanm merged 7 commits from 8613-addFkClaimDestinationFk into dev 2025-02-24 15:09:26 +00:00
Conversation 1 Commits 7 Files Changed 2 +15
ivanm commented 2025-02-20 17:34:49 +00:00
Member
Copy Link
No description provided.
ivanm added 1 commit 2025-02-20 17:34:50 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
723eaed19b refactor: refs #8613 add fk to claimEnd.claimDestinationFk
ivanm added 1 commit 2025-02-20 18:18:03 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
348cda6054 Merge branch 'dev' into 8613-addFkClaimDestinationFk
ivanm added 1 commit 2025-02-21 10:47:25 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
69485dca75 Merge branch 'dev' into 8613-addFkClaimDestinationFk
ivanm added 1 commit 2025-02-21 11:21:25 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
726825164d refactor: refs #8613 alter table default 1
ivanm commented 2025-02-21 11:27:18 +00:00
Author
Member
Copy Link

He puesto default 1 en el alter table y el update también a 1 porque me parece el mejor valor en caso de que no se pase ninguno. Explicación dada en el redmine. Si ves mejor otra opción lo modifico.

He puesto default 1 en el alter table y el update también a 1 porque me parece el mejor valor en caso de que no se pase ninguno. Explicación dada en el redmine. Si ves mejor otra opción lo modifico.
ivanm requested review from jgallego 2025-02-21 11:27:52 +00:00
jgallego requested changes 2025-02-21 13:51:22 +00:00
Dismissed
db/versions/11444-orangeMastic/01-firstScript.sql Outdated
@ -0,0 +4,4 @@
FOREIGN KEY (claimDestinationFk)
REFERENCES claimDestination(id)
ON UPDATE CASCADE
ON DELETE CASCADE;
jgallego commented 2025-02-21 13:51:20 +00:00
Owner
Copy Link

ací en delete restrict, perque si algu tira a borrar un tipo de claim destination, no volem que borre en cascada totes les claimEnd que hi haja.

ací en delete restrict, perque si algu tira a borrar un tipo de claim destination, no volem que borre en cascada totes les claimEnd que hi haja.
ivanm marked this conversation as resolved
ivanm added 1 commit 2025-02-24 11:18:11 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
8e6eeca5e8 refactor: refs #8613 change on delete to restrict
ivanm added 1 commit 2025-02-24 11:38:10 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
218bb4db6f Merge branch 'dev' into 8613-addFkClaimDestinationFk
ivanm requested review from jgallego 2025-02-24 11:55:03 +00:00
jgallego approved these changes 2025-02-24 15:03:50 +00:00
ivanm added 1 commit 2025-02-24 15:05:39 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
85fb754bc9 Merge branch 'dev' into 8613-addFkClaimDestinationFk
ivanm merged commit 3330db84fa into dev 2025-02-24 15:09:26 +00:00
ivanm deleted branch 8613-addFkClaimDestinationFk 2025-02-24 15:09:26 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#3479
No description provided.
Delete Branch "8613-addFkClaimDestinationFk"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?