Added client consumption campaign filter #400

Merged
joan merged 6 commits from 2481-campaign_filter into dev 2020-10-06 06:50:34 +00:00
Contributor
No description provided.
joan changed title from WIP: Added filter to Added client consumption campaign filter 2020-10-05 06:56:25 +00:00
carlosjr requested changes 2020-10-05 09:33:26 +00:00
@ -0,0 +1,18 @@
const app = require('vn-loopback/server/server');
describe('campaign latest()', () => {
Contributor

add a test for the filter getting results for previous years

add a test for the filter getting results for previous years
carlosjr marked this conversation as resolved
@ -0,0 +1,16 @@
const app = require('vn-loopback/server/server');
describe('campaign upcoming()', () => {
Contributor

some tests should be added for dinamic dates

some tests should be added for dinamic dates
joan marked this conversation as resolved
@ -0,0 +1,30 @@
module.exports = Self => {
Self.remoteMethod('upcoming', {
description: 'Returns the lastest campaigns',
Contributor

if a single result is expected should then be singular campain

if a single result is expected should then be singular campain
@ -196,0 +209,4 @@
this.input.value = display;
/* if (this.translateFields.indexOf(this.showField) > -1)
Contributor

delete this

delete this
@ -0,0 +17,4 @@
}));
describe('getUpcomingCampaing()', () => {
it(`should make an HTTP GET query`, () => {
Contributor

information is missing

information is missing
carlosjr approved these changes 2020-10-05 12:50:58 +00:00
carlosjr left a comment
Contributor

GGs

GGs
joan merged commit 530a4026f8 into dev 2020-10-06 06:50:33 +00:00
joan deleted branch 2481-campaign_filter 2020-10-06 06:50:40 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#400
No description provided.