verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

2534 - Fill sage data before enable taxDataChecked #432

Merged
carlosjr merged 3 commits from 2534-sage_taxDataChecked into dev 2020-11-04 12:54:15 +00:00
Conversation 0 Commits 3 Files Changed 8 +52 -13
joan commented 2020-10-28 13:19:18 +00:00
Contributor
Copy Link
No description provided.
carlosjr requested changes 2020-11-04 12:30:02 +00:00
modules/client/back/methods/client/specs/updateFiscalData.spec.js
@ -26,0 +26,4 @@
expect(error.message).toEqual(`You can't make changes on a client with verified data`);
});
it('should return an error if the user is not d and the isTaxDataChecked value is true', async() => {
carlosjr commented 2020-11-04 12:25:07 +00:00
Contributor
Copy Link

who is d?

who is d?
joan marked this conversation as resolved
modules/client/front/fiscal-data/index.html Outdated
@ -31,3 +31,3 @@
order="transaction">
</vn-crud-model>
<form name="form" ng-submit="$ctrl.onSubmit()" class="vn-w-md">
<form name="form" ng-submit="$ctrl.onSubmit()" class="vn-w-md" disabled="true">
carlosjr commented 2020-11-04 12:29:44 +00:00
Contributor
Copy Link

disabled not needed

disabled not needed
carlosjr approved these changes 2020-11-04 12:39:53 +00:00
carlosjr left a comment
Contributor
Copy Link

LGTM

LGTM
carlosjr merged commit 47b845da46 into dev 2020-11-04 12:54:15 +00:00
carlosjr deleted branch 2534-sage_taxDataChecked 2020-11-04 12:54:20 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
carlosjr
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#432
No description provided.
Delete Branch "2534-sage_taxDataChecked"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?