verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 67 Releases Wiki Activity

2425-ticket_descriptor_menu #447

Merged
carlosjr merged 11 commits from 2425-ticket_descriptor_menu into dev 2020-11-11 13:45:02 +00:00
Conversation 0 Commits 11 Files Changed 88 +1061 -842
joan commented 2020-11-10 06:47:10 +00:00
Contributor
Copy Link
No description provided.
joan changed title from 2425-ticket_descriptor_menu to WIP: 2425-ticket_descriptor_menu 2020-11-10 06:47:32 +00:00
joan changed title from WIP: 2425-ticket_descriptor_menu to 2425-ticket_descriptor_menu 2020-11-11 06:31:12 +00:00
joan requested review from bernat 2020-11-11 08:18:48 +00:00
joan requested review from carlosjr 2020-11-11 08:18:50 +00:00
carlosjr requested changes 2020-11-11 10:34:39 +00:00
carlosjr left a comment
Contributor
Copy Link

just found some comments in the code

just found some comments in the code
loopback/locale/es.json Outdated
@ -161,2 +161,3 @@
"The nif cannot be empty": "El NIF no puede quedar en blanco",
"You need to fill sage information before you check verified data": "Debes rellenar la información de sage antes de marcar datos comprobados"
"You need to fill sage information before you check verified data": "Debes rellenar la información de sage antes de marcar datos comprobados",
"ASSIGN_ZONE_FIRST": "ASSIGN_ZONE_FIRST"
carlosjr commented 2020-11-11 10:30:34 +00:00
Contributor
Copy Link

this doesn't look good

this doesn't look good
modules/ticket/front/descriptor/index.spec.js Outdated
@ -29,3 +29,2 @@
$httpBackend = _$httpBackend_;
$httpBackend.whenGET(`Tickets/${ticket.id}/canHaveStowaway`).respond(true);
$httpBackend.expect('GET', `Tickets/${ticket.id}/isEditable`).respond(true);
// $httpBackend.whenGET(`Tickets/${ticket.id}/canHaveStowaway`).respond(true);
carlosjr commented 2020-11-11 10:32:30 +00:00
Contributor
Copy Link

this doesn't look good at all xD

this doesn't look good at all xD
modules/ticket/front/summary/index.js
@ -32,0 +34,4 @@
.then(() => {
if (this.card)
this.card.reload();
// Refresh index model
carlosjr commented 2020-11-11 10:33:38 +00:00
Contributor
Copy Link

not needed?

not needed?
joan marked this conversation as resolved
carlosjr approved these changes 2020-11-11 13:05:29 +00:00
carlosjr left a comment
Contributor
Copy Link

LGTM

LGTM
carlosjr approved these changes 2020-11-11 13:43:04 +00:00
carlosjr left a comment
Contributor
Copy Link

LGTM

LGTM
carlosjr merged commit 795d371dc8 into dev 2020-11-11 13:45:02 +00:00
carlosjr deleted branch 2425-ticket_descriptor_menu 2020-11-11 13:45:09 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
bernat
carlosjr
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#447
No description provided.
Delete Branch "2425-ticket_descriptor_menu"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?