verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

2587-supplier_minor_changes #458

Merged
carlosjr merged 5 commits from 2587-supplier_minor_changes into dev 2020-11-19 08:42:01 +00:00
Conversation 0 Commits 5 Files Changed 18 +175 -76
bernat commented 2020-11-18 11:13:25 +00:00
Contributor
Copy Link
No description provided.
carlosjr requested changes 2020-11-18 12:52:16 +00:00
modules/supplier/front/index/index.js Outdated
@ -6,3 +15,4 @@
ngModule.vnComponent('vnSupplierIndex', {
template: require('./index.html'),
controller: Controller
carlosjr commented 2020-11-18 12:37:17 +00:00
Contributor
Copy Link

This line doesn't look any good.

This line doesn't look any good.
modules/supplier/front/summary/index.html
@ -24,0 +54,4 @@
value="{{$ctrl.summary.SageTransactionType.transaction}}">
</vn-label-value>
<vn-label-value label="Sage withholding"
value="{{$ctrl.summary.sageWithholding.withholding}}">
carlosjr commented 2020-11-18 12:35:18 +00:00
Contributor
Copy Link

vn-tooltip or title missing.

vn-tooltip or title missing.
carlosjr marked this conversation as resolved
carlosjr approved these changes 2020-11-19 08:13:53 +00:00
carlosjr left a comment
Contributor
Copy Link

LGTM

LGTM
carlosjr merged commit 1ec1d6d81c into dev 2020-11-19 08:42:00 +00:00
carlosjr deleted branch 2587-supplier_minor_changes 2020-11-19 08:42:07 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
carlosjr
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#458
No description provided.
Delete Branch "2587-supplier_minor_changes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?