verdnatura/salix
verdnatura
/
salix
3
5
Fork 0
Code Issues Pull Requests 54 Releases Wiki Activity

2587-supplier_minor_changes #458

Merged
carlosjr merged 5 commits from 2587-supplier_minor_changes into dev 2020-11-19 08:42:01 +00:00
Conversation 0 Commits 5 Files Changed 18 +58 -36
2 changed files with 58 additions and 36 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 85b2c96ffd - Show all commits

1
modules/supplier/front/index/index.js
View File

@ -15,5 +15,4 @@ export default class Controller extends Section {
ngModule.vnComponent('vnSupplierIndex', { ngModule.vnComponent('vnSupplierIndex', {
template: require('./index.html'), template: require('./index.html'),
controller: Controller controller: Controller
}); });
carlosjr commented 2020-11-18 12:37:17 +00:00
Outdated
Review
Copy Link

This line doesn't look any good.

This line doesn't look any good.

93
modules/supplier/front/summary/index.html
View File

@ -1,14 +1,16 @@
<vn-card class="summary"> <vn-card class="summary">
<h5>{{$ctrl.summary.name}} - {{$ctrl.summary.id}}</h5> <h5>{{::$ctrl.summary.name}} - {{::$ctrl.summary.id}}</h5>
<vn-horizontal> <vn-horizontal>
<vn-one> <vn-one>
<h4 translate>Basic data</h4> <h4 translate>Basic data</h4>
<vn-vertical> <vn-vertical>
<vn-label-value label="Id" <vn-label-value
value="{{$ctrl.summary.id}}"> label="Id"
value="{{::$ctrl.summary.id}}">
</vn-label-value> </vn-label-value>
<vn-label-value label="Alias" <vn-label-value
value="{{$ctrl.summary.nickname}}"> label="Alias"
value="{{::$ctrl.summary.nickname}}">
</vn-label-value> </vn-label-value>
<vn-check <vn-check
label="Verified" label="Verified"
@ -20,24 +22,29 @@
ng-model="$ctrl.summary.isActive" ng-model="$ctrl.summary.isActive"
disabled="true"> disabled="true">
</vn-check> </vn-check>
<vn-label-value label="Notes" <vn-label-value
value="{{$ctrl.summary.note}}"> label="Notes"
value="{{::$ctrl.summary.note}}">
</vn-label-value> </vn-label-value>
</vn-vertical> </vn-vertical>
</vn-one> </vn-one>
<vn-one> <vn-one>
<h4 translate>Billing data</h4> <h4 translate>Billing data</h4>
<vn-label-value label="Pay method" <vn-label-value
value="{{$ctrl.summary.payMethod.name}}"> label="Pay method"
value="{{::$ctrl.summary.payMethod.name}}">
</vn-label-value> </vn-label-value>
<vn-label-value label="Payment deadline" <vn-label-value
value="{{$ctrl.summary.payDem.payDem}}"> label="Payment deadline"
value="{{::$ctrl.summary.payDem.payDem}}">
</vn-label-value> </vn-label-value>
<vn-label-value label="Pay day" <vn-label-value
value="{{$ctrl.summary.payDay}}"> label="Pay day"
value="{{::$ctrl.summary.payDay}}">
</vn-label-value> </vn-label-value>
<vn-label-value label="Account" <vn-label-value
value="{{$ctrl.summary.account}}"> label="Account"
value="{{::$ctrl.summary.account}}">
</vn-label-value> </vn-label-value>
<vn-check <vn-check
label="Is Farmer" label="Is Farmer"
@ -45,40 +52,56 @@
disabled="true"> disabled="true">
</vn-check> </vn-check>
</vn-one> </vn-one>
</vn-horizontal>
<vn-horizontal>
<vn-one> <vn-one>
carlosjr marked this conversation as resolved
carlosjr commented 2020-11-18 12:35:18 +00:00
Review
Copy Link

vn-tooltip or title missing.

vn-tooltip or title missing.
<h4 translate>Fiscal data</h4> <h4 translate>Fiscal data</h4>
<vn-label-value label="Sage tax type" <vn-label-value
value="{{$ctrl.summary.sageTaxType.vat}}"> label="Sage tax type"
value="{{::$ctrl.summary.sageTaxType.vat}}">
</vn-label-value> </vn-label-value>
<vn-label-value label="Sage transaction type" <vn-label-value
value="{{$ctrl.summary.SageTransactionType.transaction}}"> title="{{::$ctrl.summary.sageTransactionType.transaction}}"
label="Sage transaction type"
value="{{::$ctrl.summary.sageTransactionType.transaction}}">
</vn-label-value> </vn-label-value>
<vn-label-value label="Sage withholding" <vn-label-value
value="{{$ctrl.summary.sageWithholding.withholding}}"> title="{{::$ctrl.summary.sageWithholding.withholding}}"
label="Sage withholding"
value="{{::$ctrl.summary.sageWithholding.withholding}}">
</vn-label-value> </vn-label-value>
</vn-one> </vn-one>
</vn-horizontal>
<vn-horizontal>
<vn-one> <vn-one>
<h4 translate>Fiscal address</h4> <h4 translate>Fiscal address</h4>
<vn-label-value label="Social name" <vn-label-value
value="{{$ctrl.summary.name}}"> label="Social name"
value="{{::$ctrl.summary.name}}">
</vn-label-value> </vn-label-value>
<vn-label-value label="Tax number" <vn-label-value
value="{{$ctrl.summary.nif}}"> label="Tax number"
value="{{::$ctrl.summary.nif}}">
</vn-label-value> </vn-label-value>
<vn-label-value label="Street" ellipsize="false" <vn-label-value
value="{{$ctrl.summary.street}}"> label="Street"
value="{{::$ctrl.summary.street}}">
</vn-label-value> </vn-label-value>
<vn-label-value label="City" <vn-label-value
value="{{$ctrl.summary.city}}"> label="City"
value="{{::$ctrl.summary.city}}">
</vn-label-value> </vn-label-value>
<vn-label-value label="Postcode" <vn-label-value
value="{{$ctrl.summary.postCode}}"> label="Postcode"
value="{{::$ctrl.summary.postCode}}">
</vn-label-value> </vn-label-value>
<vn-label-value label="Province" <vn-label-value
value="{{$ctrl.summary.province.name}}"> label="Province"
value="{{::$ctrl.summary.province.name}}">
</vn-label-value> </vn-label-value>
<vn-label-value label="Country" <vn-label-value
value="{{$ctrl.summary.country.country}}"> label="Country"
value="{{::$ctrl.summary.country.country}}">
</vn-label-value> </vn-label-value>
</vn-one> </vn-one>
</vn-horizontal> </vn-horizontal>