2576 - Photo upload component #470

Merged
carlosjr merged 11 commits from 2576-photo_uploader into dev 2020-12-21 09:55:54 +00:00
Contributor
No description provided.
joan added 2 commits 2020-12-10 12:21:30 +00:00
joan added 1 commit 2020-12-11 14:05:20 +00:00
gitea/salix/pipeline/head This commit looks good Details
0a4016be41
Updated unit tests & changed ACL
joan added 1 commit 2020-12-14 06:46:47 +00:00
gitea/salix/pipeline/head This commit looks good Details
d7dde7e4eb
Updated e2e
joan requested review from carlosjr 2020-12-14 09:49:49 +00:00
joan added 1 commit 2020-12-18 16:23:20 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
42cd2356a2
Refactor v2
joan added 2 commits 2020-12-18 16:25:25 +00:00
joan added 1 commit 2020-12-18 16:29:18 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
95df28fc35
Keep file
joan added 1 commit 2020-12-18 17:03:03 +00:00
gitea/salix/pipeline/head This commit looks good Details
6717853efb
Updated front tests
joan changed title from WIP: 2576 - Photo upload component to 2576 - Photo upload component 2020-12-18 17:06:26 +00:00
joan added 1 commit 2020-12-21 09:14:31 +00:00
gitea/salix/pipeline/head This commit looks good Details
027a37bdad
Requested changes
carlosjr requested changes 2020-12-21 09:49:34 +00:00
@ -0,0 +3,4 @@
describe('image upload()', () => {
afterEach(() => {
// RESTORE NODE ENV
delete process.env.NODE_ENV;
Contributor

discard

discard
carlosjr marked this conversation as resolved
@ -0,0 +47,4 @@
expect(containerModel.upload).toHaveBeenCalled();
});
it('should throw an error to upload a photo on test environment', async() => {
Contributor

discard

discard
@ -0,0 +50,4 @@
if (process.env.NODE_ENV == 'test')
throw new UserError(`You can't upload images on the test instance`);
await TempContainer.allowedContentTypes();
Contributor

discard

discard
carlosjr approved these changes 2020-12-21 09:51:08 +00:00
carlosjr left a comment
Contributor

LGTM

LGTM
carlosjr merged commit ffc9b8dba9 into dev 2020-12-21 09:55:54 +00:00
carlosjr deleted branch 2576-photo_uploader 2020-12-21 09:56:13 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#470
No description provided.