verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

2547-supplier_billing_data #477

Merged
carlosjr merged 3 commits from 2547-supplier_billing_data into dev 2020-12-15 09:10:19 +00:00
Conversation 0 Commits 3 Files Changed 10 +218 -1
Ghost commented 2020-12-15 08:31:15 +00:00
First-time contributor
Copy Link
No description provided.
Ghost added 2 commits 2020-12-15 08:31:16 +00:00
carlosjr requested changes 2020-12-15 08:50:42 +00:00
modules/supplier/back/models/supplier.js Outdated
@ -73,0 +81,4 @@
if (payMethod && payMethod.ibanRequired && !hasIban)
err();
done();
carlosjr commented 2020-12-15 08:46:37 +00:00
Contributor
Copy Link

missing trailling space

missing trailling space
Ghost added 1 commit 2020-12-15 09:01:56 +00:00
gitea/salix/pipeline/head This commit looks good Details
8e11cef8eb Code review refactor
carlosjr approved these changes 2020-12-15 09:03:35 +00:00
carlosjr left a comment
Contributor
Copy Link

LGTM

LGTM
carlosjr merged commit 21a2ba25b4 into dev 2020-12-15 09:10:19 +00:00
carlosjr deleted branch 2547-supplier_billing_data 2020-12-15 09:10:50 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
carlosjr
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#477
No description provided.
Delete Branch "2547-supplier_billing_data"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?