verdnatura/salix
verdnatura
/
salix
3
5
Fork 0
Code Issues Pull Requests 65 Releases Wiki Activity

2667-create_entryObservation #490

Merged
joan merged 4 commits from 2667-create_entryObservation into dev 2020-12-24 08:59:36 +00:00
Conversation 0 Commits 4 Files Changed 11 +169 -6
Ghost commented 2020-12-23 11:34:24 +00:00
First-time contributor
Copy Link
No description provided.
Ghost added 2 commits 2020-12-23 11:34:25 +00:00
gitea/salix/pipeline/head This commit looks good Details
2948747da3 Seccion nueva, "Note" mas campo entryObservation
joan requested changes 2020-12-23 11:57:25 +00:00
joan left a comment
Contributor
Copy Link

Some changes needed

Some changes needed
modules/entry/back/models/entry-observation.js
@ -0,0 +3,4 @@
module.exports = Self => {
Self.rewriteDbError(function(err) {
if (err.code === 'ER_DUP_ENTRY')
return new UserError(`The observation type can't be repeated`);
joan commented 2020-12-23 11:54:18 +00:00
Contributor
Copy Link

Falta la traducción de esto

Falta la traducción de esto
Ghost marked this conversation as resolved
modules/entry/back/models/entry-observation.json
@ -0,0 +26,4 @@
"type": "belongsTo",
"model": "Entry",
"foreignKey": "entryFk",
"required": true
joan commented 2020-12-23 11:53:44 +00:00
Contributor
Copy Link

La propiedad required en las relaciones no hace nada.

La propiedad required en las relaciones no hace nada.
Ghost marked this conversation as resolved
joan requested changes 2020-12-23 12:03:02 +00:00
modules/entry/front/note/index.html
@ -0,0 +61,4 @@
disabled="!watcher.dataChanged()"
label="Save">
</vn-submit>
<!-- # #2680 Undo changes button bugs -->
joan commented 2020-12-23 12:02:46 +00:00
Contributor
Copy Link

¿Este comentario es necesario?

¿Este comentario es necesario?
Ghost marked this conversation as resolved
Ghost added 2 commits 2020-12-23 12:33:12 +00:00
gitea/salix/pipeline/head This commit looks good Details
259842c22d Retirado el parametro required por no utilizarse
joan approved these changes 2020-12-24 08:59:00 +00:00
joan left a comment
Contributor
Copy Link

LGTM

LGTM
joan merged commit c192a0e125 into dev 2020-12-24 08:59:36 +00:00
joan deleted branch 2667-create_entryObservation 2020-12-24 08:59:56 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
joan
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#490
No description provided.
Delete Branch "2667-create_entryObservation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?