WIP: 2583-create_supplierAccount_section #508

Closed
Ghost wants to merge 0 commits from 2583-create_supplierAccount_section into dev
First-time contributor
No description provided.
Ghost added 5 commits 2021-01-12 07:15:02 +00:00
joan requested changes 2021-01-20 07:26:11 +00:00
@ -0,0 +1 @@
INSERT INTO `salix`.`ACL` (`model`, `property`, `accessType`, `permission`, `principalType`, `principalId`) VALUES ('SupplierAccount', '*', '*', 'ALLOW', 'ROLE', 'administrative');
Contributor

Mover ficheros sql a versión 10271

Mover ficheros sql a versión 10271
Ghost marked this conversation as resolved
Ghost added 61 commits 2021-01-21 08:57:10 +00:00
gitea/salix/pipeline/head This commit looks good Details
61bb2f14ba
LDAP sync hotfix
gitea/salix/pipeline/head This commit looks good Details
b2a3adc96f
LDAP sync hotfix
gitea/salix/pipeline/head This commit looks good Details
954ba0c69d
Back replicas
gitea/salix/pipeline/head This commit looks good Details
fc9412bddd
Merge branch 'master' into test
gitea/salix/pipeline/head This commit looks good Details
49111e3d73
Replicas removed from compose
gitea/salix/pipeline/head This commit looks good Details
cc9f313867
Docker replicas restored
gitea/salix/pipeline/head This commit looks good Details
6f6f23bec4
LDAP user sync only syncs changed attributes
gitea/salix/pipeline/head This commit looks good Details
d064bc0417
Merge branch 'master' into test
gitea/salix/pipeline/head This commit looks good Details
292a46106e
Translation fix
gitea/salix/pipeline/head This commit looks good Details
e5b13267e2
2605 - Ticket request send chat notification
gitea/salix/pipeline/head This commit looks good Details
779b229dfc
refactor tag fixtures
gitea/salix/pipeline/head This commit looks good Details
2a948ddc33
Merge pull request 'refactor tag fixtures' (#502) from 2707-fixtures_tag into dev
Reviewed-on: #502
Reviewed-by: Carlos Jimenez Ruiz <carlosjr@verdnatura.es>
gitea/salix/pipeline/head This commit looks good Details
c623a5d1e4
Merge branch 'dev' into 2605-ticket_request_chat
gitea/salix/pipeline/head This commit looks good Details
418774e5e0
Merge pull request '2605 - Ticket request send chat notification' (#500) from 2605-ticket_request_chat into dev
Reviewed-on: #500
Reviewed-by: Carlos Jimenez Ruiz <carlosjr@verdnatura.es>
gitea/salix/pipeline/head This commit looks good Details
a2550ce128
export table payment
gitea/salix/pipeline/head This commit looks good Details
f8ba2534cc
2691 - Scope days changes
gitea/salix/pipeline/head This commit looks good Details
6184681d7b
Merge branch 'dev' into 2713-export_payment
gitea/salix/pipeline/head This commit looks good Details
eecbdec7ad
Merge pull request 'export table payment' (#504) from 2713-export_payment into dev
Reviewed-on: #504
Reviewed-by: Javi Gallego <jgallego@verdnatura.es>
gitea/salix/pipeline/head This commit looks good Details
ffdc753ad4
2691 - Added "or" between date ranges and scope days
gitea/salix/pipeline/head This commit looks good Details
b5676d40b4
Merge branch 'dev' into 2691-ticket_scope_days
gitea/salix/pipeline/head This commit looks good Details
035bdfb1ad
Rounded box
gitea/salix/pipeline/head This commit looks good Details
7568a1c066
Updated unit tests
gitea/salix/pipeline/head This commit looks good Details
ac12d72c65
Merge pull request '2691 - Added "or" between date ranges and scope days' (#505) from 2691-ticket_scope_days into dev
Reviewed-on: #505
Reviewed-by: Carlos Jimenez Ruiz <carlosjr@verdnatura.es>
gitea/salix/pipeline/head This commit looks good Details
4435f5e1b0
Vn-th sortable icon hotfix
gitea/salix/pipeline/head This commit looks good Details
880093921e
Vn-th sortable icon hotfix
gitea/salix/pipeline/head This commit looks good Details
509de4fa0a
Fix for good practique code
gitea/salix/pipeline/head This commit looks good Details
b4899fc0ff
Fix for good practique code
gitea/salix/pipeline/head This commit looks good Details
1a4c631c70
Fix for good practique code
gitea/salix/pipeline/head This commit looks good Details
78d9b40828
Merge pull request '2650-add_button_edit_on_summaries' (#507) from 2650-add_button_edit_on_summaries into dev
Reviewed-on: #507
Reviewed-by: Carlos Jimenez Ruiz <carlosjr@verdnatura.es>
gitea/salix/pipeline/head This commit looks good Details
dd29b351d2
Disabled loggable
gitea/salix/pipeline/head This commit looks good Details
7bcad01bef
Disabled loggable
gitea/salix/pipeline/head This commit looks good Details
b1613871e1
Merge pull request '2672-trigger_itemTag' (#509) from 2672-trigger_itemTag into dev
Reviewed-on: #509
Reviewed-by: Javi Gallego <jgallego@verdnatura.es>
gitea/salix/pipeline/head This commit looks good Details
5059abca80
Dms edit hotfix
gitea/salix/pipeline/head This commit looks good Details
0e9160f61b
Letter debtor hotfix
gitea/salix/pipeline/head This commit looks good Details
53e80d29c8
Consumption hotfix
gitea/salix/pipeline/head This commit looks good Details
fe6124b691
Put log in the section
Ghost added 1 commit 2021-01-21 09:49:24 +00:00
gitea/salix/pipeline/head This commit looks good Details
05d6484a33
Add message if BIC already exist
Ghost added 1 commit 2021-01-21 09:55:24 +00:00
gitea/salix/pipeline/head This commit looks good Details
6acb5c221e
Changes folder of ACL
Ghost requested review from joan 2021-01-21 10:21:50 +00:00
carlosjr added 1 commit 2021-01-21 11:05:27 +00:00
carlosjr requested changes 2021-01-22 10:25:15 +00:00
@ -0,0 +1,11 @@
module.exports = Self => {
Contributor

duplicated code, models are shared between modules. Move the existing one to back for generic use.

duplicated code, models are shared between modules. Move the existing one to back for generic use.
@ -0,0 +16,4 @@
url="BankEntities"
fields="['countryFk','id','name', 'bic']"
data="bankEntities"
auto-load="true">
Contributor

boolean seems to always be true, and indetate this code.

Move the type bankEntity autocomplete to the left of the iban input as per forms standards

Make sure the new bankEntity is shown on the bankEntity autocomplete upon creation.

boolean seems to always be true, and indetate this code. Move the type bankEntity autocomplete to the left of the iban input as per forms standards Make sure the new bankEntity is shown on the bankEntity autocomplete upon creation.
@ -0,0 +23,4 @@
<vn-horizontal ng-repeat="supplierAccount in $ctrl.supplierAccounts">
<vn-autocomplete vn-two vn-focus
label="Bank entity"
initial-data="$ctrl.getName(bankEntity)"
Contributor

getName does not exist on the controller

getName does not exist on the controller
@ -0,0 +26,4 @@
initial-data="$ctrl.getName(bankEntity)"
ng-model="supplierAccount.bankEntityFk"
data="bankEntities"
on-change="$ctrl.getName(bankEntity)"
Contributor

getName does not exist on the controller

getName does not exist on the controller
@ -0,0 +65,4 @@
<vn-submit
disabled="!watcher.dataChanged()"
label="Save">
</vn-submit>
Contributor

onResponse doesn't exist in the controller and if this is correct please use on-accept instead of on-response when you want to handle only the accept

onResponse doesn't exist in the controller and if this is correct please use on-accept instead of on-response when you want to handle only the accept
@ -0,0 +27,4 @@
});
}
showBankEntity(event) {
Contributor

This method is never invoqued in the template.

This method is never invoqued in the template.
@ -0,0 +33,4 @@
this.$.bankEntity.show();
}
onBankEntityAccept() {
Contributor

This method is never invoqued in the template.

This method is never invoqued in the template.
@ -0,0 +57,4 @@
countryFk: 1,
id: 2200
};
$httpBackend.expectPATCH(`SupplierAccounts/${controller.$.bankEntity.id}/createBankEntity`).respond({id: 2200});
Contributor

extract long queries to constants please

extract long queries to constants please
@ -0,0 +18,4 @@
<vn-horizontal>
<vn-textfield
vn-one
vn-focus
Contributor

use a single vn-focus per template

use a single vn-focus per template
@ -0,0 +6,4 @@
resetLocation() {
this.location = {};
}
Contributor

No new line between declarationseslint.

move this component to front/salix/components.

rename compoent folder to bank-entity (lower snake case).

No new line between declarationseslint. move this component to front/salix/components. rename compoent folder to bank-entity (lower snake case).
@ -0,0 +10,4 @@
onOpen() {
this.location = {};
this.$.bankentity.focus();
}
Contributor

this method is never invoqued in the template!

this method is never invoqued in the template!
@ -0,0 +19,4 @@
this.$http.post(`Bankentities`, this.location).then(() => {
this.vnApp.showMessage(this.$t('The bank entity has been created. You can save the data now'));
this.emit('response', {$response: this.location});
});
Contributor

Calling a route by an incorrect name. (model config) "name": "BankEntity"

Calling a route by an incorrect name. (model config) "name": "BankEntity"
@ -0,0 +20,4 @@
if (!this.location.countryFk)
throw new Error(`The country can't be empty`);
this.$http.patch(`bankentities`, this.location).then(() => {
Contributor

there's no spanish translation for this string

there's no spanish translation for this string
@ -0,0 +35,4 @@
ngModule.vnComponent('vnNewBankentity', {
template: require('./index.html'),
controller: Controller,
Contributor

shouldn't be location?

shouldn't be location?
@ -0,0 +1,11 @@
New postcode: Nuevo código postal
Contributor

all this translations are duplicated code. please avoid copy pastes!

all this translations are duplicated code. please avoid copy pastes!
@ -8,6 +8,8 @@ import './search-panel';
import './summary';
import './basic-data';
import './fiscal-data';
import './bankentity';
Contributor

this name should be lower snake case

this name should be lower snake case
@ -9,6 +9,7 @@
{"state": "supplier.index", "icon": "icon-supplier"}
],
"card": [
{"state": "supplier.card.account", "icon": "face"},
Contributor

"contact_support" icon ?

"contact_support" icon ?
carlosjr added the
Needs refactor
label 2021-01-22 10:26:31 +00:00
carlosjr added 2 commits 2021-01-22 10:29:11 +00:00
Ghost added 2 commits 2021-02-11 17:54:23 +00:00
carlosjr requested changes 2021-02-12 12:40:50 +00:00
@ -3,3 +1,1 @@
INSERT INTO `salix`.`ACL` (`model`, `property`, `accessType`, `permission`, `principalType`, `principalId`) VALUES ('Client', 'createReceipt', '*', 'ALLOW', 'ROLE', 'administrative');
INSERT INTO salix.ACL (model, property, accessType, permission, principalType, principalId)
VALUES ('PrintServerQueue', '*', 'WRITE', 'ALLOW', 'ROLE', 'employee');
INSERT INTO `salix`.`ACL` (`model`, `property`, `accessType`, `permission`, `principalType`, `principalId`)
Contributor

move the relevant sql statements to the correct folder

move the relevant sql statements to the correct folder
Ghost added 2 commits 2021-02-12 14:20:23 +00:00
Ghost closed this pull request 2021-02-17 11:34:27 +00:00
Some checks are pending
gitea/salix/pipeline/head This commit looks good
gitea/salix/pipeline/pr-*
Required

Pull request closed

Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#508
No description provided.