WIP: 2583-create_supplierAccount_section #508
Closed
Ghost
wants to merge 0 commits from
2583-create_supplierAccount_section
into dev
pull from: 2583-create_supplierAccount_section
merge into: verdnatura:dev
verdnatura:dev
verdnatura:7899-deleteUnusedStates
verdnatura:8139-clockInCampaign
verdnatura:test
verdnatura:7917-freelancerRoute
verdnatura:master
verdnatura:revert_7283_itemMigration3
verdnatura:8077-sumDefaulter
verdnatura:7709-supplierPackaging_ReportSource_2
verdnatura:7301-itemLastEntries
verdnatura:6389-changesMonitor
verdnatura:7134-supplierBalance
verdnatura:8099-AddSalarySupplements
verdnatura:7289_sales_already_moved
verdnatura:7151-dms_refactor_methods
verdnatura:8002-refactorToLilium
verdnatura:8190-entry_getCommission
verdnatura:8114-removeAutoAddress
verdnatura:7119-vehicle_module
verdnatura:4774-translationsVn
verdnatura:7127-ModifyDaysToAddSales
verdnatura:8007-salesByWeek
verdnatura:hotFix_newOrder_redirect
verdnatura:6583-addOnlyDestination
verdnatura:7950-cmr
verdnatura:6822-entryTransfer
verdnatura:6427_sms_resetPassword
verdnatura:4948-procTicketSelfConsumption
verdnatura:6452-useIdAsSip
verdnatura:8174-crearTablaSim
verdnatura:7202-AddCustomAgentFkColumn
verdnatura:7921-sendLostExpeditions
verdnatura:7880-hedera.order_confirmWithUserTranslations
verdnatura:7731-clientViesCode
verdnatura:8124-enrutadoresGrafana
verdnatura:7146-AddRoute.dated
verdnatura:sergiodt-patch-1
verdnatura:4774-traductions
verdnatura:6242-AddHasRoundingField
verdnatura:6403-useServiceWeightOnCreateShipment
verdnatura:4409-binlog
verdnatura:8058-test-ticketsUrgentes
verdnatura:grantSelectToDelivery
verdnatura:8075-master-itemShelvingMoving
verdnatura:8069-hotFix-oversTocking
verdnatura:7793_sortByWeight
verdnatura:7906-remakeMethod
verdnatura:hotfix_redirect_to_lilium
verdnatura:7781-revertCommit
verdnatura:7906-optimizeDeleteZone
verdnatura:fix_isWorker_defaulter
verdnatura:7965-unifyProblems
verdnatura:6695-docker_push
verdnatura:6943_customer_redirectToLilium
verdnatura:4466-facturas-recibidas
verdnatura:use_params_q
verdnatura:6321_negative_tickets
verdnatura:8012-packagingIsVisible
verdnatura:hotfix_administrativeACL
verdnatura:recupero-version-anterior
verdnatura:solve_merge_problems
verdnatura:7763-renameItemShelvings
verdnatura:7677_vnLocation_perf
verdnatura:6553-workerBusiness
verdnatura:7760-tmp.ticketIPT
verdnatura:5926_pda_worker_docuware
verdnatura:6156-advanceTicketsNewField
verdnatura:6156-advanceTickets_improve
verdnatura:5938_fine_ticketAdvance
verdnatura:7671_dense_itemFixedPrices
verdnatura:7931-availableFix
verdnatura:7897_down_masterTest_2436
verdnatura:7897_masterTest_24_36
verdnatura:6682-Retorno-errores-de-VIAEXPRESS
verdnatura:7896_down_devToTest_2436
verdnatura:7686-onPrevious
verdnatura:7896_devToTest_2436
verdnatura:7283_itemFixedPrice_duplicated
verdnatura:7287-reasonLog
verdnatura:7283-itemMigration
verdnatura:7884_daysBackward
verdnatura:7864_testToMaster_2434
verdnatura:hotfix_nightTask_supplierDisable
verdnatura:7860-packagingBox
verdnatura:7763_rename_itemShelving
verdnatura:1234-test
verdnatura:7760-Refactorizar-collection_assign
verdnatura:7644-optimizedBarcode
verdnatura:InvoiceOut_Migration
verdnatura:6941-dmsHasFile
verdnatura:7736-Añadir-parámetro-itemFk-a-buyUltimate
verdnatura:hotfix-SuppliersList
verdnatura:hotfix_myEntries
verdnatura:hotfix_entry_getBuys_fields
verdnatura:7401-redirectRouteToLilium
verdnatura:7716-travel_setDelivered
verdnatura:7765-packingDefaultWeight
verdnatura:7126-improvedWaste
verdnatura:7648_myEntries
verdnatura:7752-fixSelect
verdnatura:7486-fixCollectionAssign
verdnatura:6403-removeConsoleLog
verdnatura:6403-feat-add-mrw-delete-on-salix
verdnatura:7642_createNewState
verdnatura:6861_reservas_retro
verdnatura:6802-Clientes-gestionados-por-equipos
verdnatura:7380_substitutionCondition
verdnatura:floranet240708
verdnatura:7648_warmFix_filterByFI
verdnatura:6436_jasmine_beforeAll
verdnatura:7654-entry_splitByShelving
verdnatura:7195_roadmap2
verdnatura:7580_setParking
verdnatura:7648_customerEntries
verdnatura:5447-TravelExtraCommunity
verdnatura:7377-deleteItems
verdnatura:7404-stockBuyed-refactor
verdnatura:6264_log_tmp_renewToken
verdnatura:6264_log_renewToken
verdnatura:7539_labelers_emergency
verdnatura:5576_CGI_imagenes
verdnatura:5576-reestructurar-directorio-imagenes
verdnatura:6744-hotfix-showChangePassword
verdnatura:5770_sambaGroups
verdnatura:warmfix-defaultersFilters
verdnatura:7563_report_PDF_HTML
verdnatura:4560-GastosReparto
verdnatura:7195_roadMaps
verdnatura:6753-TicketsSaveSign
verdnatura:7523--ledger_next-transacciones
verdnatura:6367-blankNotification
verdnatura:7144-diagnoseProductionFailure
verdnatura:7400-Contador-asientos-contables
verdnatura:5919-locker
verdnatura:7143-packing-clientes/proveedores
verdnatura:6739-transferInvoiceOut
verdnatura:178899-buy_beforeDelete
verdnatura:4074-download-user-ACL
verdnatura:6533_myLogger_model
verdnatura:7025-NotifyOnSave
verdnatura:6731-fixTicketRequestLog
verdnatura:6899-endInvoiceOutMigration
verdnatura:6974-fixComparativeLog
verdnatura:6641-checkboxMyTeam
verdnatura:5890-itemShelving_asignado
verdnatura:6021-fix-role-floranet
verdnatura:hotfixClientDisable
verdnatura:6493-refactorizar-procedimientos-vn2008-parte2
verdnatura:7124_autofocus_first_input
verdnatura:6276-nodifyNewWarehouse
verdnatura:6302-deleteTicketAfterAddTurn
verdnatura:6276_newWarehouse
verdnatura:6276-newWareshouse
verdnatura:7037-Añadir-vn.client.hasDailyInvoice
verdnatura:7004_hotFix_newSupplier
verdnatura:6372--Fix-tables
verdnatura:6387-addDepartmentToQueue
verdnatura:6987-addDeparmentExtension
verdnatura:6067-checking_boxes
verdnatura:5186-createParkingBack
verdnatura:6871-createMailAliasAndRedirection
verdnatura:6372-errors-test
verdnatura:6372-ExpenseManual-Error
verdnatura:6272-fixFiscal
verdnatura:6878-addManualTimeEntries
verdnatura:6372-Delete-views-from-vn2008
verdnatura:6531_showTickets
verdnatura:2687_travel_cloneWithEntries
verdnatura:5834-billingDataAutoFillBic
verdnatura:fixTestBack
verdnatura:6235-addDeviceWorkerTimeControl
verdnatura:6757-Modify-UPPER-supplier
verdnatura:6408_ricket_ticket_setState
verdnatura:6451_insomnia
verdnatura:5739-dockerRefactor
verdnatura:6489-authSupport
verdnatura:6656-workerTimeControlAcl
verdnatura:6656-hotfix-modifyWorkerTimeControlACL
verdnatura:6322-futureTicketImporte
verdnatura:6291-comprobarDNI
verdnatura:6280_consignee_postalCode
verdnatura:6587_dms_uploadFile_test
verdnatura:6456-refactor-ticketState
verdnatura:6172_transfer_ticket_message_error
verdnatura:2160_docuware_hasEditable
verdnatura:6398-fix
verdnatura:6028_routesbyWorker
verdnatura:6434-improve-signInLog
verdnatura:5914-warmFix-transferInvoice
verdnatura:6434-signInLog_improve
verdnatura:hotfix-ticketAddresFk
verdnatura:5633-accountShortToStandard
verdnatura:4515-itemWeight
verdnatura:4879-item-generic
verdnatura:4707-test-workerTimeControl
verdnatura:6287-Ticket.create-no-usarlo
verdnatura:4707-tests_workerTimeControl
verdnatura:5867-driverRoutePdf
verdnatura:5768-incoterms
verdnatura:5890-ItemShelvingSale_asignado
verdnatura:4671-Regularizar-el-calculo-de-los-componentes
verdnatura:6230-itemModifyBasicData
verdnatura:6067-accountPermisos
verdnatura:6194-goLabelLink
verdnatura:6132-modify-saveSign
verdnatura:5669-ticket.volume_fix
verdnatura:5881-fixDbChanges
verdnatura:hotfix_test_renewToken
verdnatura:3126-changes
verdnatura:6082-refactNav
verdnatura:1877-ticket_basic-data_update
verdnatura:1877-ticket_basic-data
verdnatura:5729-aumentarCredito
verdnatura:6043-fixeE2E
verdnatura:5947-worker_create
verdnatura:5888-address-autocomplete_component
verdnatura:hotfix_workCenter
verdnatura:5964-supplyValidation
verdnatura:5874-refactor_makeInvoice
verdnatura:5891_inventory_parking
verdnatura:4770-routes_roadmap
verdnatura:5295-notificarGerencia-itemCategory
verdnatura:hotfix_renewToken
verdnatura:warnfix_summaryTravel
verdnatura:4466-facturas-rectificativas
verdnatura:5739-refactor-dockerfile
verdnatura:5394-descriptor-popovers-logs
verdnatura:5691-route.index_sustituirUrlporData
verdnatura:5737-claimSales
verdnatura:5630-ticket.expedition_borrarEtiquetas
verdnatura:5160-backTest_jenkins2
verdnatura:5468-account.priveleges_conLasValidacionesQueJuanNoQuiere
verdnatura:5654-portesRecogida
verdnatura:5455-quitSkipsE2E
verdnatura:5160-backTest_jenkins
verdnatura:4764-abonoTicketService
verdnatura:5066-order-vehicle-by-warehouse
verdnatura:hotfix_arcRfid
verdnatura:5446-HOTFIX
verdnatura:5213-minorBugsAdministración
verdnatura:3946-permisos
verdnatura:5414-searchBar_deleteChips
verdnatura:4975-Send-in-upload-access
verdnatura:3074-invoiceIn-Tax-crear-total
verdnatura:5081-fix-sms-error-on-ticket
verdnatura:4825-intrastat
verdnatura:5001-nueva-notificación-cobros-web-perdidos
verdnatura:4943-closeTickets
verdnatura:4560-gastos-reparto
verdnatura:fix-invoiceIn
verdnatura:TEST_hotflix_backTest
verdnatura:print_vue3
verdnatura:MASTER_hotfix_deleteTrashFiles
verdnatura:dev_hotfix_updateDiscount
verdnatura:3557-Refactor-collectionFaults-into-collection_missingTrash
verdnatura:entry.buy_import_xls
verdnatura:#2570-entry-add-recalc
verdnatura:3868-secure_password_change
verdnatura:2268-db_instances
Reference in New Issue
No description provided.
Delete Branch "2583-create_supplierAccount_section"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
@ -0,0 +1 @@
INSERT INTO `salix`.`ACL` (`model`, `property`, `accessType`, `permission`, `principalType`, `principalId`) VALUES ('SupplierAccount', '*', '*', 'ALLOW', 'ROLE', 'administrative');
Mover ficheros sql a versión 10271
@ -0,0 +1,11 @@
module.exports = Self => {
duplicated code, models are shared between modules. Move the existing one to back for generic use.
@ -0,0 +16,4 @@
url="BankEntities"
fields="['countryFk','id','name', 'bic']"
data="bankEntities"
auto-load="true">
boolean seems to always be true, and indetate this code.
Move the type bankEntity autocomplete to the left of the iban input as per forms standards
Make sure the new bankEntity is shown on the bankEntity autocomplete upon creation.
@ -0,0 +23,4 @@
<vn-horizontal ng-repeat="supplierAccount in $ctrl.supplierAccounts">
<vn-autocomplete vn-two vn-focus
label="Bank entity"
initial-data="$ctrl.getName(bankEntity)"
getName does not exist on the controller
@ -0,0 +26,4 @@
initial-data="$ctrl.getName(bankEntity)"
ng-model="supplierAccount.bankEntityFk"
data="bankEntities"
on-change="$ctrl.getName(bankEntity)"
getName does not exist on the controller
@ -0,0 +65,4 @@
<vn-submit
disabled="!watcher.dataChanged()"
label="Save">
</vn-submit>
onResponse doesn't exist in the controller and if this is correct please use on-accept instead of on-response when you want to handle only the accept
@ -0,0 +27,4 @@
});
}
showBankEntity(event) {
This method is never invoqued in the template.
@ -0,0 +33,4 @@
this.$.bankEntity.show();
}
onBankEntityAccept() {
This method is never invoqued in the template.
@ -0,0 +57,4 @@
countryFk: 1,
id: 2200
};
$httpBackend.expectPATCH(`SupplierAccounts/${controller.$.bankEntity.id}/createBankEntity`).respond({id: 2200});
extract long queries to constants please
@ -0,0 +18,4 @@
<vn-horizontal>
<vn-textfield
vn-one
vn-focus
use a single vn-focus per template
@ -0,0 +6,4 @@
resetLocation() {
this.location = {};
}
No new line between declarationseslint.
move this component to front/salix/components.
rename compoent folder to bank-entity (lower snake case).
@ -0,0 +10,4 @@
onOpen() {
this.location = {};
this.$.bankentity.focus();
}
this method is never invoqued in the template!
@ -0,0 +19,4 @@
this.$http.post(`Bankentities`, this.location).then(() => {
this.vnApp.showMessage(this.$t('The bank entity has been created. You can save the data now'));
this.emit('response', {$response: this.location});
});
Calling a route by an incorrect name. (model config) "name": "BankEntity"
@ -0,0 +20,4 @@
if (!this.location.countryFk)
throw new Error(`The country can't be empty`);
this.$http.patch(`bankentities`, this.location).then(() => {
there's no spanish translation for this string
@ -0,0 +35,4 @@
ngModule.vnComponent('vnNewBankentity', {
template: require('./index.html'),
controller: Controller,
shouldn't be location?
@ -0,0 +1,11 @@
New postcode: Nuevo código postal
all this translations are duplicated code. please avoid copy pastes!
@ -8,6 +8,8 @@ import './search-panel';
import './summary';
import './basic-data';
import './fiscal-data';
import './bankentity';
this name should be lower snake case
@ -9,6 +9,7 @@
{"state": "supplier.index", "icon": "icon-supplier"}
],
"card": [
{"state": "supplier.card.account", "icon": "face"},
"contact_support" icon ?
@ -3,3 +1,1 @@
INSERT INTO `salix`.`ACL` (`model`, `property`, `accessType`, `permission`, `principalType`, `principalId`) VALUES ('Client', 'createReceipt', '*', 'ALLOW', 'ROLE', 'administrative');
INSERT INTO salix.ACL (model, property, accessType, permission, principalType, principalId)
VALUES ('PrintServerQueue', '*', 'WRITE', 'ALLOW', 'ROLE', 'employee');
INSERT INTO `salix`.`ACL` (`model`, `property`, `accessType`, `permission`, `principalType`, `principalId`)
move the relevant sql statements to the correct folder
Pull request closed