verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 67 Releases Wiki Activity

entry index changes #515

Merged
carlosjr merged 12 commits from 2589-entry_index into dev 2021-04-01 14:49:46 +00:00
Conversation 0 Commits 12 Files Changed 3 +20 -14
bernat commented 2021-01-19 11:51:46 +00:00
Contributor
Copy Link
No description provided.
bernat added 1 commit 2021-01-19 11:51:46 +00:00
gitea/salix/pipeline/head This commit looks good Details
426249f9bf entry index changes
bernat added 1 commit 2021-01-19 12:44:23 +00:00
gitea/salix/pipeline/head This commit looks good Details
e9f408d5ba delete comments
bernat changed title from entry index changes to WIP: entry index changes 2021-01-19 13:06:02 +00:00
joan approved these changes 2021-01-19 13:24:42 +00:00
joan left a comment
Contributor
Copy Link

LGTM

LGTM
joan added 1 commit 2021-01-20 07:30:01 +00:00
gitea/salix/pipeline/head This commit looks good Details
b04eadbe79 Merge branch 'dev' into 2589-entry_index
joan requested changes 2021-01-20 07:47:48 +00:00
modules/entry/back/methods/entry/filter.js
joan commented 2021-01-20 07:47:37 +00:00
Contributor
Copy Link

No funciona correctamente en test si se ordena por t.landed

No funciona correctamente en test si se ordena por t.landed
joan marked this conversation as resolved
modules/entry/back/methods/entry/filter.js Outdated
@ -157,1 +159,4 @@
);
stmt.merge(conn.makeWhere(filter.where));
stmt.merge(conn.makeGroupBy('b.entryFk'));
stmt.merge(conn.makeOrderBy('t.landed DESC'));
joan commented 2021-01-20 07:33:58 +00:00
Contributor
Copy Link

El orderBy no debería estar hardcodeado

El orderBy no debería estar hardcodeado
joan marked this conversation as resolved
bernat added 2 commits 2021-01-20 10:31:28 +00:00
bernat added 1 commit 2021-01-20 10:42:55 +00:00
gitea/salix/pipeline/head This commit looks good Details
0f17fca0a1 pr order by changes
bernat added 1 commit 2021-01-21 08:45:30 +00:00
gitea/salix/pipeline/head This commit looks good Details
678ee0644d delete order by in entry index
bernat added 1 commit 2021-01-21 09:06:28 +00:00
bernat changed title from WIP: entry index changes to entry index changes 2021-01-21 13:48:55 +00:00
jgallego was assigned by joan 2021-01-21 14:08:58 +00:00
joan added 2 commits 2021-04-01 11:53:23 +00:00
gitea/salix/pipeline/head This commit looks good Details
389f10bda0 Removed entry import
joan added 1 commit 2021-04-01 11:56:27 +00:00
gitea/salix/pipeline/head This commit looks good Details
91c26ee5a5 Removed filter import
joan added 1 commit 2021-04-01 12:02:01 +00:00
gitea/salix/pipeline/head This commit looks good Details
fa0b01a0d5 Fixed buttons alignment
carlosjr approved these changes 2021-04-01 14:17:31 +00:00
carlosjr left a comment
Contributor
Copy Link

LGTM

LGTM
joan approved these changes 2021-04-01 14:18:57 +00:00
carlosjr merged commit 129d3373d0 into dev 2021-04-01 14:49:46 +00:00
carlosjr deleted branch 2589-entry_index 2021-04-01 14:49:57 +00:00
jgallego removed their assignment 2024-10-15 07:12:11 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
carlosjr
joan
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#515
No description provided.
Delete Branch "2589-entry_index"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?