2692-add_advanced_search_engine2 #519
No reviewers
Labels
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: verdnatura/salix#519
Loading…
Reference in New Issue
No description provided.
Delete Branch "2692-add_advanced_search_engine2"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
@ -0,0 +12,4 @@
describe('fetchParams()', () => {
it('should return a range of dates with passed scope days', () => {
function diffInDays(a, b) {
This test is a copy paste of a bad test implementation. please tests the $params modification following the tests standards
@ -0,0 +49,4 @@
expect(params.scopeDays).toEqual(2);
});
it('should throw an error when scope days has a string value', () => {
when receiving invalid scope days
@ -0,0 +51,4 @@
it('should throw an error when scope days has a string value', () => {
let params = controller.fetchParams({
scopeDays: 'prueba'
should be 'invalid scopeDays' for example
@ -0,0 +34,4 @@
let params = controller.fetchParams({
scopeDays: 0
});
if (!params || params.scopeDays == '0')
remove this.
@ -0,0 +44,4 @@
let params = controller.fetchParams({
scopeDays: 2
});
if (typeof params.scopeDays === 'number')
remove this.
@ -0,0 +53,4 @@
let params = controller.fetchParams({
scopeDays: 'prueba'
});
if (typeof params.scopeDays !== 'number')
remove this.
LGTM