2692-add_advanced_search_engine2 #519

Merged
carlosjr merged 20 commits from 2692-add_advanced_search_engine2 into dev 2021-02-02 12:29:23 +00:00
First-time contributor
No description provided.
Ghost added 2 commits 2021-01-20 12:37:31 +00:00
Ghost added 1 commit 2021-01-20 13:37:32 +00:00
Ghost added 1 commit 2021-01-20 13:48:58 +00:00
gitea/salix/pipeline/head This commit looks good Details
e205ebba72
Added main spec and fixed line on search-panel spec
carlosjr added 1 commit 2021-01-22 10:33:02 +00:00
carlosjr added 1 commit 2021-01-22 11:02:30 +00:00
gitea/salix/pipeline/head This commit looks good Details
5ea222dc00
fixed translations
carlosjr added the
Missing tests
label 2021-01-22 11:05:19 +00:00
carlosjr requested changes 2021-01-22 11:05:45 +00:00
@ -0,0 +12,4 @@
describe('fetchParams()', () => {
it('should return a range of dates with passed scope days', () => {
function diffInDays(a, b) {
Contributor

This test is a copy paste of a bad test implementation. please tests the $params modification following the tests standards

This test is a copy paste of a bad test implementation. please tests the $params modification following the tests standards
carlosjr marked this conversation as resolved
Ghost added 4 commits 2021-01-29 07:55:16 +00:00
Ghost removed the
Missing tests
label 2021-02-01 11:25:22 +00:00
carlosjr requested changes 2021-02-01 11:49:50 +00:00
@ -0,0 +49,4 @@
expect(params.scopeDays).toEqual(2);
});
it('should throw an error when scope days has a string value', () => {
Contributor

when receiving invalid scope days

when receiving invalid scope days
@ -0,0 +51,4 @@
it('should throw an error when scope days has a string value', () => {
let params = controller.fetchParams({
scopeDays: 'prueba'
Contributor

should be 'invalid scopeDays' for example

should be 'invalid scopeDays' for example
Ghost added 2 commits 2021-02-01 12:14:00 +00:00
Ghost added 1 commit 2021-02-01 12:19:14 +00:00
gitea/salix/pipeline/head This commit looks good Details
3f963f2d99
changed message
Ghost added 2 commits 2021-02-02 09:26:22 +00:00
carlosjr added the
Needs refactor
label 2021-02-02 10:39:00 +00:00
carlosjr requested changes 2021-02-02 10:42:12 +00:00
@ -0,0 +34,4 @@
let params = controller.fetchParams({
scopeDays: 0
});
if (!params || params.scopeDays == '0')
Contributor

remove this.

remove this.
carlosjr marked this conversation as resolved
@ -0,0 +44,4 @@
let params = controller.fetchParams({
scopeDays: 2
});
if (typeof params.scopeDays === 'number')
Contributor

remove this.

remove this.
carlosjr marked this conversation as resolved
@ -0,0 +53,4 @@
let params = controller.fetchParams({
scopeDays: 'prueba'
});
if (typeof params.scopeDays !== 'number')
Contributor

remove this.

remove this.
Ghost added 2 commits 2021-02-02 10:57:52 +00:00
Ghost added 1 commit 2021-02-02 11:52:26 +00:00
gitea/salix/pipeline/head This commit looks good Details
1a87eb3085
Remove bad code
Ghost added 1 commit 2021-02-02 12:11:26 +00:00
gitea/salix/pipeline/head This commit looks good Details
b576c0ad69
Remove parenthesis on expectedParams
Ghost added 1 commit 2021-02-02 12:18:33 +00:00
gitea/salix/pipeline/head This commit looks good Details
186e59c7ae
.
carlosjr removed the
Needs refactor
label 2021-02-02 12:28:30 +00:00
carlosjr approved these changes 2021-02-02 12:29:07 +00:00
carlosjr left a comment
Contributor

LGTM

LGTM
carlosjr merged commit 1379b52d8a into dev 2021-02-02 12:29:23 +00:00
carlosjr deleted branch 2692-add_advanced_search_engine2 2021-02-02 12:29:35 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#519
No description provided.