2617-add_scope_days_on_travel_index #530

Merged
carlosjr merged 18 commits from 2617-add_scope_days_on_travel_index into dev 2021-02-02 13:33:35 +00:00
First-time contributor
No description provided.
Ghost added 11 commits 2021-01-29 10:41:38 +00:00
Ghost added 1 commit 2021-01-29 10:45:44 +00:00
gitea/salix/pipeline/head This commit looks good Details
b600c18950
Add scope days on travel
carlosjr requested changes 2021-02-01 11:54:25 +00:00
@ -0,0 +51,4 @@
it('should throw an error when scope days has a string value', () => {
let params = controller.fetchParams({
scopeDays: 'prueba'
Contributor

ie: invalid scopeDays

ie: invalid scopeDays
carlosjr marked this conversation as resolved
Ghost added 1 commit 2021-02-01 12:24:35 +00:00
Ghost added 8 commits 2021-02-02 09:27:41 +00:00
carlosjr added 1 commit 2021-02-02 10:00:28 +00:00
carlosjr requested changes 2021-02-02 10:41:33 +00:00
@ -0,0 +34,4 @@
let params = controller.fetchParams({
scopeDays: 0
});
if (!params || params.scopeDays == '0')
Contributor

remove this.

remove this.
carlosjr marked this conversation as resolved
@ -0,0 +44,4 @@
let params = controller.fetchParams({
scopeDays: 2
});
if (typeof params.scopeDays === 'number')
Contributor

remove this.

remove this.
carlosjr marked this conversation as resolved
@ -0,0 +53,4 @@
let params = controller.fetchParams({
scopeDays: 'prueba'
});
if (typeof params.scopeDays !== 'number')
Contributor

remove this.

remove this.
carlosjr marked this conversation as resolved
carlosjr added the
Needs refactor
label 2021-02-02 10:41:53 +00:00
Ghost added 3 commits 2021-02-02 10:50:08 +00:00
Ghost added 2 commits 2021-02-02 11:39:35 +00:00
gitea/salix/pipeline/head This commit looks good Details
218a19d7da
Removed bad code
Ghost added 1 commit 2021-02-02 12:14:37 +00:00
gitea/salix/pipeline/head This commit looks good Details
b57578f933
Remove parenthesis on expectedParams
carlosjr removed the
Needs refactor
label 2021-02-02 12:30:06 +00:00
carlosjr added 3 commits 2021-02-02 13:04:28 +00:00
carlosjr approved these changes 2021-02-02 13:05:23 +00:00
carlosjr left a comment
Contributor

LGTM

LGTM
carlosjr added 1 commit 2021-02-02 13:13:43 +00:00
carlosjr approved these changes 2021-02-02 13:14:03 +00:00
carlosjr left a comment
Contributor

LGTM

LGTM
carlosjr merged commit fcbf157c20 into dev 2021-02-02 13:33:35 +00:00
carlosjr deleted branch 2617-add_scope_days_on_travel_index 2021-02-02 13:33:51 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#530
No description provided.